No longer invoke setAccessible() when on PHP 8.1+

See xp-framework/test#24

Author: thekid

src/main/php/lang/reflection/Method.class.php

@@ -51,7 +51,10 @@ public function closure(?object $instance= null) {
   public function invoke(?object $instance, $args= []) {
     try {
       $pass= PHP_VERSION_ID < 80000 && $args ? self::pass($this->reflect, $args) : $args;
-      $this->reflect->setAccessible(true);
+
+      // TODO: Remove superfluous call to setAccessible() if on PHP8.1+
+      // see https://wiki.php.net/rfc/make-reflection-setaccessible-no-op
+      PHP_VERSION_ID < 80100 && $this->reflect->setAccessible(true);
       return $this->reflect->invokeArgs($instance, $pass);
     } catch (ReflectionException|ArgumentCountError|TypeError $e) {
       throw new CannotInvoke($this, $e);

src/main/php/lang/reflection/Property.class.php

@@ -77,7 +77,7 @@ public function get(?object $instance) {
 
       // TODO: Remove superfluous call to setAccessible() if on PHP8.1+
       // see https://wiki.php.net/rfc/make-reflection-setaccessible-no-op
-      $this->reflect->setAccessible(true);
+      PHP_VERSION_ID < 80100 && $this->reflect->setAccessible(true);
       return $this->reflect->getValue($instance);
     } catch (ReflectionException $e) {
       throw new CannotAccess($this, $e);
@@ -100,7 +100,7 @@ public function set(?object $instance, $value) {
 
       // TODO: Remove superfluous call to setAccessible() if on PHP8.1+
       // see https://wiki.php.net/rfc/make-reflection-setaccessible-no-op
-      $this->reflect->setAccessible(true);
+      PHP_VERSION_ID < 80100 && $this->reflect->setAccessible(true);
       $this->reflect->setValue($instance, $value);
       return $value;
     } catch (ReflectionException $e) {

src/main/php/lang/reflection/Type.class.php

@@ -170,7 +170,11 @@ public function initializer($function) {
     } else if ($this->reflect->hasMethod($function)) {
       $reflect= $this->reflect->getMethod($function);
       return new Initializer($this->reflect, $reflect, function($instance, $args) use($reflect) {
-        $reflect->setAccessible(true);
+
+        // TODO: Remove superfluous call to setAccessible() if on PHP8.1+
+        // see https://wiki.php.net/rfc/make-reflection-setaccessible-no-op
+        PHP_VERSION_ID < 80100 && $reflect->setAccessible(true);
+
         return $reflect->invokeArgs($instance, $args);
       });
     }