Fix lang.reflection.Constant::modifiers() return type

Author: thekid

ChangeLog.md

@@ -3,6 +3,10 @@ XP Reflection ChangeLog
 
 ## ?.?.? / ????-??-??
 
+### 2.13.3 / 2023-06-04
+
+* Fixed `lang.reflection.Constant::modifiers()` return type - @thekid
+
 ### 2.13.2 / 2023-06-04
 
 * Fixed reading and writing non-public virtual properties - @thekid

src/main/php/lang/reflection/Constant.class.php

@@ -40,9 +40,6 @@ public function constraint() {
     return new Constraint($t ?? Type::$VAR, $present);
   }
 
-  /** @return int */
-  public function modifiers() { return $this->reflect->getModifiers(); }
-
   /** @return var */
   public function value() { return $this->reflect->getValue(); }
 

src/test/php/lang/reflection/unittest/ConstantsTest.class.php

@@ -58,19 +58,19 @@ public function named() {
   #[Test, Runtime(php: '>=7.1')]
   public function private_constant() {
     $const= $this->declare('{ private const FIXTURE = "test"; }')->constant('FIXTURE');
-    Assert::equals([MODIFIER_PRIVATE, 'test'], [$const->modifiers(), $const->value()]);
+    Assert::equals([MODIFIER_PRIVATE, 'test'], [$const->modifiers()->bits(), $const->value()]);
   }
 
   #[Test, Runtime(php: '>=7.1')]
   public function protected_constant() {
     $const= $this->declare('{ protected const FIXTURE = "test"; }')->constant('FIXTURE');
-    Assert::equals([MODIFIER_PROTECTED, 'test'], [$const->modifiers(), $const->value()]);
+    Assert::equals([MODIFIER_PROTECTED, 'test'], [$const->modifiers()->bits(), $const->value()]);
   }
 
   #[Test, Runtime(php: '>=7.1')]
   public function public_constant() {
     $const= $this->declare('{ public const FIXTURE = "test"; }')->constant('FIXTURE');
-    Assert::equals([MODIFIER_PUBLIC, 'test'], [$const->modifiers(), $const->value()]);
+    Assert::equals([MODIFIER_PUBLIC, 'test'], [$const->modifiers()->bits(), $const->value()]);
   }
 
   #[Test]