config.go: Don't add unecessary fields to default config

Signed-off-by: xplshn <xplshn@murena.io>

Author: xplshn

config.go

@@ -43,8 +43,8 @@ type config struct {
 	RetakeOwnership     bool         `yaml:"RetakeOwnership" env:"DBIN_REOWN" description:"Retake ownership of installed binaries."`
 	UseIntegrationHooks bool         `yaml:"IntegrationHooks" env:"DBIN_USEHOOKS" description:"Use integration hooks for binaries."`
 	DisableProgressbar  bool         `yaml:"DisablePbar,omitempty" env:"DBIN_NOPBAR" description:"Disable the progress bar."`
-	NoConfig            bool         `env:"DBIN_NOCONFIG" description:"Disable configuration file usage."`
-	ProgressbarFIFO     bool         `env:"DBIN_PB_FIFO" description:"Use FIFO for progress bar."`
+	NoConfig            bool         `yaml:"-" env:"DBIN_NOCONFIG" description:"Disable configuration file usage."`
+	ProgressbarFIFO     bool         `yaml:"-" env:"DBIN_PB_FIFO" description:"Use FIFO for progress bar."`
 	Hooks               hooks        `yaml:"Hooks,omitempty"`
 }
 
@@ -356,6 +356,7 @@ func createDefaultConfigAt(configFilePath string) error {
 				IntegrationCommand:   "sh -c \"$DBIN info > ${DBIN_CACHE_DIR}/.info\"",
 				DeintegrationCommand: "sh -c \"$DBIN info > ${DBIN_CACHE_DIR}/.info\"",
 				UseRunFromCache:      true,
+				Silent:               true,
 				NoOp:                 false,
 			},
 		},

fetch.go

@@ -12,6 +12,7 @@ import (
 	"regexp"
 	"strings"
 	"syscall"
+	"time"
 
 	"github.com/goccy/go-json"
 	"github.com/hedzr/progressbar"
@@ -515,3 +516,50 @@ func downloadOCILayer(ctx context.Context, registry, repository string, manifest
 	}
 	return binaryResp, sigResp, nil
 }
+
+// cleanTempFiles removes .tmp files in the InstallDir that haven't been accessed in over a day.
+func cleanInstallCache(installDir string) error {
+    const oneDay = 24 * time.Hour
+    now := time.Now()
+
+    entries, err := os.ReadDir(installDir)
+    if err != nil {
+        return errFileAccess.Wrap(err)
+    }
+
+    for _, entry := range entries {
+        if entry.IsDir() || !strings.HasSuffix(entry.Name(), ".tmp") {
+            continue
+        }
+
+        filePath := filepath.Join(installDir, entry.Name())
+        fileInfo, err := os.Stat(filePath)
+        if err != nil {
+            if verbosityLevel >= silentVerbosityWithErrors {
+                fmt.Fprintf(os.Stderr, "Error accessing file info for %s: %v\n", filePath, err)
+            }
+            continue
+        }
+        var atime time.Time
+        if sysInfo, ok := fileInfo.Sys().(*syscall.Stat_t); ok {
+            atime = time.Unix(sysInfo.Atim.Sec, sysInfo.Atim.Nsec)
+        } else {
+            if verbosityLevel >= extraVerbose {
+                fmt.Fprintf(os.Stderr, "Warning: ATime not supported for %s, skipping cleanup\n", filePath)
+            }
+            continue
+        }
+
+        if now.Sub(atime) > oneDay {
+            if err := os.Remove(filePath); err != nil {
+                if verbosityLevel >= silentVerbosityWithErrors {
+                    fmt.Fprintf(os.Stderr, "Error removing old .tmp file %s: %v\n", filePath, err)
+                }
+            } else if verbosityLevel >= extraVerbose {
+                fmt.Printf("Removed old .tmp file: %s\n", filePath)
+            }
+        }
+    }
+
+    return nil
+}

install.go

@@ -40,6 +40,13 @@ func installBinaries(ctx context.Context, config *config, bEntries []binaryEntry
 	cursor.Hide()
 	defer cursor.Show()
 
+	// Clean up old .tmp files before installation
+    if err := cleanInstallCache(config.InstallDir); err != nil {
+        if verbosityLevel >= silentVerbosityWithErrors {
+            fmt.Fprintf(os.Stderr, "Warning: Failed to clean up .tmp files in %s: %v\n", config.InstallDir, err)
+        }
+    }
+
 	var wg sync.WaitGroup
 	var errors []string
 	var errorsMu sync.Mutex

run.go

@@ -64,7 +64,7 @@ func runFromCache(config *config, bEntry binaryEntry, args []string, transparent
 		if err := runBinary(cachedFile, args, env); err != nil {
 			return errRunFailed.Wrap(err)
 		}
-		return cleanCache(config.CacheDir)
+		return cleanRunCache(config.CacheDir)
 	}
 
 	if verbosityLevel >= normalVerbosity {
@@ -94,7 +94,7 @@ func runFromCache(config *config, bEntry binaryEntry, args []string, transparent
 	if err := runBinary(cachedFile, args, env); err != nil {
 		return errRunFailed.Wrap(err)
 	}
-	return cleanCache(config.CacheDir)
+	return cleanRunCache(config.CacheDir)
 }
 
 func isCached(config *config, bEntry binaryEntry) (string, error) {
@@ -129,7 +129,7 @@ func runBinary(binaryPath string, args []string, env []string) error {
 	return errRunFailed.Wrap(err)
 }
 
-func cleanCache(cacheDir string) error {
+func cleanRunCache(cacheDir string) error {
 	files, err := os.ReadDir(cacheDir)
 	if err != nil {
 		return errRunFailed.Wrap(err)