-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Describe the bug
The fastapi_kwargs argument added with PR #9, is intended to allow users to set kwargs for the FastAPI instance created by the create_app function.
However, this library appears to be spinning up additional instance of FastAPI without provide those instances those keyword arguments. This leads to incorrect behavior, for example setting a root_path when behind a proxy; The root FastAPI instance will correctly handle url prefixes, but nested endpoints (handled by one of these other FastAPI instances) will not.
To Reproduce
Steps to reproduce the behavior:
- Run application behind a proxy.
- Set
root_apiparameter usingfastapi_kwargsarugment. - Issue call against docs (/{root_path}/docs/ to verify proxy correctly serves JS.
- Issue call against item in catalogs (/{root_path}/docs/{catalog}).
- Reroute from catalog pathway will not have root_path included..
Expected behavior
The root_path (prefix) should be included in urls handled by the other FastAPI instances.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels