Assert metrics in aiohttp-server tests

Author: xrmx

instrumentation/opentelemetry-instrumentation-aiohttp-server/tests/test_aiohttp_server_integration.py

@@ -19,6 +19,7 @@
 import pytest
 import pytest_asyncio
 
+from opentelemetry import metrics as metrics_api
 from opentelemetry import trace as trace_api
 from opentelemetry.instrumentation.aiohttp_server import (
     AioHttpServerInstrumentor,
@@ -29,7 +30,10 @@
     HTTP_STATUS_CODE,
     HTTP_URL,
 )
-from opentelemetry.test.globals_test import reset_trace_globals
+from opentelemetry.test.globals_test import (
+    reset_metrics_globals,
+    reset_trace_globals,
+)
 from opentelemetry.test.test_base import TestBase
 from opentelemetry.util._importlib_metadata import entry_points
 
@@ -65,6 +69,20 @@ def fixture_tracer():
     reset_trace_globals()
 
 
+@pytest.fixture(name="meter", scope="session")
+def fixture_meter():
+    test_base = TestBase()
+
+    meter_provider, memory_reader = test_base.create_meter_provider()
+
+    reset_trace_globals()
+    metrics_api.set_meter_provider(meter_provider)
+
+    yield meter_provider, memory_reader
+
+    reset_metrics_globals()
+
+
 async def default_handler(request, status=200):
     return aiohttp.web.Response(status=status)
 
@@ -113,21 +131,27 @@ def test_checking_instrumentor_pkg_installed():
 )
 async def test_status_code_instrumentation(
     tracer,
+    meter,
     server_fixture,
     aiohttp_client,
     url,
     expected_method,
     expected_status_code,
 ):
     _, memory_exporter = tracer
+    _, metrics_reader = meter
     server, _ = server_fixture
 
     assert len(memory_exporter.get_finished_spans()) == 0
+    metrics = _get_sorted_metrics(metrics_reader.get_metrics_data())
+    assert len(metrics) == 0
 
     client = await aiohttp_client(server)
     await client.get(url)
 
     assert len(memory_exporter.get_finished_spans()) == 1
+    metrics = _get_sorted_metrics(metrics_reader.get_metrics_data())
+    assert len(metrics) == 2
 
     [span] = memory_exporter.get_finished_spans()
 
@@ -197,14 +221,31 @@ async def handler(request):
     memory_exporter.clear()
 
 
+def _get_sorted_metrics(metrics_data):
+    resource_metrics = metrics_data.resource_metrics if metrics_data else []
+
+    all_metrics = []
+    for metrics in resource_metrics:
+        for scope_metrics in metrics.scope_metrics:
+            all_metrics.extend(scope_metrics.metrics)
+
+    return sorted(
+        all_metrics,
+        key=lambda m: m.name,
+    )
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "env_var",
     ["OTEL_PYTHON_AIOHTTP_SERVER_EXCLUDED_URLS", "OTEL_PYTHON_EXCLUDED_URLS"],
 )
-async def test_excluded_urls(tracer, aiohttp_server, monkeypatch, env_var):
+async def test_excluded_urls(
+    tracer, meter, aiohttp_server, monkeypatch, env_var
+):
     """Test that excluded env vars are taken into account."""
     _, memory_exporter = tracer
+    _, metrics_reader = meter
 
     monkeypatch.setenv(env_var, "/status/200")
     AioHttpServerInstrumentor().instrument()
@@ -227,4 +268,7 @@ async def handler(request):
     spans = memory_exporter.get_finished_spans()
     assert len(spans) == 0
 
+    metrics = _get_sorted_metrics(metrics_reader.get_metrics_data())
+    assert len(metrics) == 0
+
     AioHttpServerInstrumentor().uninstrument()