Skip to content

Commit f7669da

Browse files
committed
Split unwrap tests in their own testcase
1 parent eb05bc5 commit f7669da

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

opentelemetry-instrumentation/tests/test_utils.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -252,29 +252,31 @@ def test_suppress_http_instrumentation_key(self):
252252

253253
self.assertIsNone(get_value(_SUPPRESS_HTTP_INSTRUMENTATION_KEY))
254254

255+
256+
class UnwrapTestCase:
255257
@staticmethod
256258
def _wrap_method():
257259
return wrap_function_wrapper(
258260
WrappedClass, "method", WrappedClass.wrapper_method
259261
)
260262

261-
def test_unwrap_can_unwrap_object_attribute(self):
263+
def test_can_unwrap_object_attribute(self):
262264
self._wrap_method()
263265
instance = WrappedClass()
264266
self.assertTrue(isinstance(instance.method, ObjectProxy))
265267

266268
unwrap(WrappedClass, "method")
267269
self.assertFalse(isinstance(instance.method, ObjectProxy))
268270

269-
def test_unwrap_can_unwrap_object_attribute_as_string(self):
271+
def test_can_unwrap_object_attribute_as_string(self):
270272
self._wrap_method()
271273
instance = WrappedClass()
272274
self.assertTrue(isinstance(instance.method, ObjectProxy))
273275

274276
unwrap("tests.test_utils.WrappedClass", "method")
275277
self.assertFalse(isinstance(instance.method, ObjectProxy))
276278

277-
def test_unwrap_raises_import_error_if_path_not_well_formed(self):
279+
def test_raises_import_error_if_path_not_well_formed(self):
278280
self._wrap_method()
279281
instance = WrappedClass()
280282
self.assertTrue(isinstance(instance.method, ObjectProxy))
@@ -287,7 +289,7 @@ def test_unwrap_raises_import_error_if_path_not_well_formed(self):
287289
unwrap(WrappedClass, "method")
288290
self.assertFalse(isinstance(instance.method, ObjectProxy))
289291

290-
def test_unwrap_raises_import_error_if_cannot_find_module(self):
292+
def test_raises_import_error_if_cannot_find_module(self):
291293
self._wrap_method()
292294
instance = WrappedClass()
293295
self.assertTrue(isinstance(instance.method, ObjectProxy))
@@ -298,7 +300,7 @@ def test_unwrap_raises_import_error_if_cannot_find_module(self):
298300
unwrap(WrappedClass, "method")
299301
self.assertFalse(isinstance(instance.method, ObjectProxy))
300302

301-
def test_unwrap_raises_import_error_if_cannot_find_object(self):
303+
def test_raises_import_error_if_cannot_find_object(self):
302304
self._wrap_method()
303305
instance = WrappedClass()
304306
self.assertTrue(isinstance(instance.method, ObjectProxy))
@@ -311,11 +313,12 @@ def test_unwrap_raises_import_error_if_cannot_find_object(self):
311313
unwrap(WrappedClass, "method")
312314
self.assertFalse(isinstance(instance.method, ObjectProxy))
313315

316+
# pylint: disable=no-self-use
314317
def test_does_nothing_if_cannot_find_attribute(self):
315318
instance = WrappedClass()
316319
unwrap(instance, "method_not_found")
317320

318-
def test_unwrap_does_nothing_if_attribute_is_not_from_wrapt(self):
321+
def test_does_nothing_if_attribute_is_not_from_wrapt(self):
319322
instance = WrappedClass()
320323
self.assertFalse(isinstance(instance.method, ObjectProxy))
321324
unwrap(WrappedClass, "method")

0 commit comments

Comments
 (0)