Skip to content

Commit 1833214

Browse files
committed
Update sdk
1 parent 7e1f42f commit 1833214

File tree

2 files changed

+23
-1
lines changed

2 files changed

+23
-1
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/__init__.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,9 @@ def create_observable_counter(
196196
self._instrument_id_instrument[instrument_id] = instrument
197197
return instrument
198198

199-
def create_histogram(self, name, unit="", description="") -> APIHistogram:
199+
def create_histogram(
200+
self, name, unit="", description="", advisory=None
201+
) -> APIHistogram:
200202
(
201203
is_instrument_registered,
202204
instrument_id,
@@ -223,6 +225,7 @@ def create_histogram(self, name, unit="", description="") -> APIHistogram:
223225
self._measurement_consumer,
224226
unit,
225227
description,
228+
advisory,
226229
)
227230
with self._instrument_id_instrument_lock:
228231
self._instrument_id_instrument[instrument_id] = instrument

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/instrument.py

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
from opentelemetry.metrics._internal.instrument import CallbackOptions
3535
from opentelemetry.sdk.metrics._internal.measurement import Measurement
3636
from opentelemetry.sdk.util.instrumentation import InstrumentationScope
37+
from opentelemetry.util.types import MetricsInstrumentAdvisory
3738

3839
_logger = getLogger(__name__)
3940

@@ -219,6 +220,24 @@ def __new__(cls, *args, **kwargs):
219220

220221

221222
class Histogram(_Synchronous, APIHistogram):
223+
def __init__(
224+
self,
225+
name: str,
226+
instrumentation_scope: InstrumentationScope,
227+
measurement_consumer: "opentelemetry.sdk.metrics.MeasurementConsumer",
228+
unit: str = "",
229+
description: str = "",
230+
advisory: MetricsInstrumentAdvisory = None,
231+
):
232+
super().__init__(
233+
name,
234+
unit=unit,
235+
description=description,
236+
instrumentation_scope=instrumentation_scope,
237+
measurement_consumer=measurement_consumer,
238+
)
239+
self._advisory = advisory
240+
222241
def __new__(cls, *args, **kwargs):
223242
if cls is Histogram:
224243
raise TypeError("Histogram must be instantiated via a meter.")

0 commit comments

Comments
 (0)