Rewrote MetricsInstrumentAdvisory as TypedDict

Author: xrmx

opentelemetry-api/src/opentelemetry/metrics/_internal/__init__.py

@@ -379,7 +379,7 @@ def create_histogram(
         name: str,
         unit: str = "",
         description: str = "",
-        advisory: MetricsInstrumentAdvisory = None,
+        advisory: Optional[MetricsInstrumentAdvisory] = None,
     ) -> Histogram:
         """Creates a :class:`~opentelemetry.metrics.Histogram` instrument
 
@@ -527,7 +527,7 @@ def create_histogram(
         name: str,
         unit: str = "",
         description: str = "",
-        advisory: MetricsInstrumentAdvisory = None,
+        advisory: Optional[MetricsInstrumentAdvisory] = None,
     ) -> Histogram:
         with self._lock:
             if self._real_meter:
@@ -688,7 +688,7 @@ def create_histogram(
         name: str,
         unit: str = "",
         description: str = "",
-        advisory: MetricsInstrumentAdvisory = None,
+        advisory: Optional[MetricsInstrumentAdvisory] = None,
     ) -> Histogram:
         """Returns a no-op Histogram."""
         if self._is_instrument_registered(

opentelemetry-api/src/opentelemetry/metrics/_internal/instrument.py

@@ -336,7 +336,7 @@ def __init__(
         name: str,
         unit: str = "",
         description: str = "",
-        advisory: MetricsInstrumentAdvisory = None,
+        advisory: Optional[MetricsInstrumentAdvisory] = None,
     ) -> None:
         pass
 
@@ -358,7 +358,7 @@ def __init__(
         name: str,
         unit: str = "",
         description: str = "",
-        advisory: MetricsInstrumentAdvisory = None,
+        advisory: Optional[MetricsInstrumentAdvisory] = None,
     ) -> None:
         super().__init__(
             name, unit=unit, description=description, advisory=advisory
@@ -380,7 +380,7 @@ def __init__(
         name: str,
         unit: str = "",
         description: str = "",
-        advisory: MetricsInstrumentAdvisory = None,
+        advisory: Optional[MetricsInstrumentAdvisory] = None,
     ) -> None:
         self._name = name
         self._unit = unit

opentelemetry-api/src/opentelemetry/util/types.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from typing import Literal, Mapping, Optional, Sequence, Tuple, Union
+from typing import Mapping, Optional, Sequence, Tuple, TypedDict, Union
 
 # This is the implementation of the "Any" type as specified by the specifications of OpenTelemetry data model for logs.
 # For more details, refer to the OTel specification:
@@ -56,7 +56,6 @@
     ...,
 ]
 
-MetricsInstrumentAdvisoryKey = Literal["ExplicitBucketBoundaries"]
-MetricsInstrumentAdvisory = Optional[
-    Mapping[MetricsInstrumentAdvisoryKey, AnyValue]
-]
+
+class MetricsInstrumentAdvisory(TypedDict):
+    ExplicitBucketBoundaries: Optional[AnyValue]

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/__init__.py

@@ -202,7 +202,7 @@ def create_histogram(
         name: str,
         unit: str = "",
         description: str = "",
-        advisory: MetricsInstrumentAdvisory = None,
+        advisory: Optional[MetricsInstrumentAdvisory] = None,
     ) -> APIHistogram:
         if advisory is not None:
             raise_error = False

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/instrument.py

@@ -227,7 +227,7 @@ def __init__(
         measurement_consumer: "opentelemetry.sdk.metrics.MeasurementConsumer",
         unit: str = "",
         description: str = "",
-        advisory: MetricsInstrumentAdvisory = None,
+        advisory: Optional[MetricsInstrumentAdvisory] = None,
     ):
         super().__init__(
             name,