Now testing for appropriate context when configuring beambeam#17
Open
ColasDroin wants to merge 1 commit intoxsuite:mainfrom
Open
Now testing for appropriate context when configuring beambeam#17ColasDroin wants to merge 1 commit intoxsuite:mainfrom
ColasDroin wants to merge 1 commit intoxsuite:mainfrom
Conversation
This was referenced Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified tests of beambeam configuration in hllhc14 and hllhc14_b1_only, to ensure that an appropriate error is triggered when the context in which the trackers are built is not on CPU.
Cf. xsuite issue #450 and xtrack PR 433.
Checklist
Mandatory:
[x] I have added tests to cover my changes
[x] All the tests are passing, including my new ones
[x] I described my changes in this PR description
Optional:
[x] The code I wrote follows good style practices (see PEP 8 and PEP 20).
[ ] I have updated the docs in relation to my changes, if applicable
[x ] I have tested also GPU contexts