Remove the numerical implementation of arc_segment_plane_intersect

Author: szymonlopaciuk

xtrack/aperture/headers/path3d.h

@@ -191,88 +191,6 @@ float_type line_segment_plane_intersect(LineSegment3D segment, const Point3D pla
 }
 
 
-//float_type arc_segment_plane_intersect(const ArcSegment3D segment, const Point3D plane_point, const Point3D normal)
-///*
-//    Return a parameter `t` such that the point at `t * segment.angle` is the point on the
-//    segment at which `plane` intersects the `segment`. The plane is defined as a
-//    pose, such that if the pose is an identity, the plane lies in the X-Y plane (z=0), or, in
-//    other words, `plane @ [0, 0, 1]^T` is the plane normal.
-//*/
-//{
-//    const float_type eps = APER_PRECISION;
-//    const float_type length = segment.length;
-//
-//    if (length <= eps) return 0.f;
-//
-//    // Extract translation T from pose (local -> world)
-//    const float_type t_x = plane_point.x;
-//    const float_type t_y = plane_point.y;
-//    const float_type t_z = plane_point.z;
-//
-//    // Extract 3rd column of rotation R (plane normal in world)
-//    const float_type n_x = normal.x;
-//    const float_type n_y = normal.y;
-//    const float_type n_z = normal.z;
-//
-//    // Let A := segment start, compute A - T
-//    const Point3D p_start = arc_segment_point_at(segment, 0);
-//    const float_type ta_x = p_start.x - t_x;
-//    const float_type ta_y = p_start.y - t_y;
-//    const float_type ta_z = p_start.z - t_z;
-//
-//    // Let B := segment end, compute B - T
-//    const Point3D p_end = arc_segment_point_at(segment, 1);
-//    const float_type tb_x = p_end.x - t_x;
-//    const float_type tb_y = p_end.y - t_y;
-//    const float_type tb_z = p_end.z - t_z;
-//
-//    /*
-//        For numerical stability we will use bisection to find the intersection point.
-//        In principle there might be two such points, but is this is not expected in
-//        practice, we go on assuming there is just one.
-//
-//        We iteratively converge on an interval where n * (A - T) and n * (B - T),
-//        the signed distances between points A, B and the plane, have different signs.
-//    */
-//    float_type n_dot_ta = n_x * ta_x + n_y * ta_y + n_z * ta_z;
-//    float_type n_dot_tb = n_x * tb_x + n_y * tb_y + n_z * tb_z;
-//
-//    /* Short-circuit if already on one of the points */
-//    if (fabs(n_dot_ta) <= eps) return 0;
-//    if (fabs(n_dot_tb) <= eps) return 1;
-//
-//    /* If no sign change assume no intersection (we assume max one intersection point) */
-//    if (signbit(n_dot_ta) == signbit(n_dot_tb)) return NAN;
-//
-//    /* Bisect */
-//    float_type d_lo = 0;
-//    float_type d_hi = 1;
-//    float_type d_mid = 0.5;
-//
-//    for (int i = 0; i < 34; i++) {
-//        d_mid = 0.5f * (d_lo + d_hi);
-//        const Point3D p_mid = arc_segment_point_at(segment, d_mid);
-//        const float_type n_dot_t_mid = n_x * (p_mid.x - t_x) + n_y * (p_mid.y - t_y) + n_z * (p_mid.z - t_z);
-//
-//        /* Solution found within precision */
-//        if (fabs(n_dot_t_mid) <= eps || (d_hi - d_lo) <= eps) {
-//            return d_mid;
-//        }
-//
-//        if (signbit(n_dot_t_mid) == signbit(n_dot_ta)) {
-//            /* If projections have the same sign, bisect on [d_mid, d_hi] */
-//            d_lo = d_mid;
-//            n_dot_ta = n_dot_t_mid;
-//        } else {
-//            /* Otherwise bisect on the interval [d_lo, d_mid] */
-//            d_hi = d_mid;
-//        }
-//    }
-//
-//    return d_mid;
-//}
-
-
 static inline void plane_to_arc_local(
     const ArcSegment3D segment,
     const Point3D plane_point,