Merge pull request #6 from xt0rted/tests

Add some tests and refactor how scripts are passed around

Author: xt0rted

.editorconfig

@@ -48,8 +48,6 @@ dotnet_style_qualification_for_property = false:error
 dotnet_style_qualification_for_method = false:error
 dotnet_style_qualification_for_event = false:error
 
-# CA1062: Validate arguments of public methods
-dotnet_diagnostic.CA1062.severity = error
 
 ## Naming Conventions
 [*.{cs,vb}]

.github/workflows/ci.yml

@@ -48,15 +48,18 @@ jobs:
         uses: actions/[email protected]
         with:
           source-url: https://nuget.pkg.github.com/xt0rted/index.json
-          dotnet-version: 6.0.x
+          dotnet-version: |
+            3.1.x
+            5.0.x
+            6.0.x
         env:
           NUGET_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - run: dotnet tool restore
 
       - run: dotnet r build
 
-      - run: dotnet r test --if-present
+      - run: dotnet r test
 
       - run: dotnet r pack -- --version-suffix ${{ env.VERSION_SUFFIX }}
 

.github/workflows/codeql-analysis.yml

@@ -7,6 +7,14 @@ on:
     branches: [main]
   schedule:
     - cron: "25 0 * * 5"
+  workflow_dispatch:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+env:
+  DOTNET_NOLOGO: true
 
 jobs:
   analyze:
@@ -28,6 +36,18 @@ jobs:
       - name: Check out repository
         uses: actions/[email protected]
 
+      # This action doesn't support comments in the global.json so for now we have to specify all sdk versions
+      - name: Set up .NET
+        uses: actions/[email protected]
+        with:
+          source-url: https://nuget.pkg.github.com/xt0rted/index.json
+          dotnet-version: |
+            3.1.x
+            5.0.x
+            6.0.x
+        env:
+          NUGET_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v1
         with:

.github/workflows/release.yml

@@ -30,7 +30,10 @@ jobs:
         uses: actions/[email protected]
         with:
           source-url: https://nuget.pkg.github.com/xt0rted/index.json
-          dotnet-version: 6.0.x
+          dotnet-version: |
+            3.1.x
+            5.0.x
+            6.0.x
         env:
           NUGET_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
@@ -44,7 +47,7 @@ jobs:
 
       - run: dotnet r build
 
-      - run: dotnet r test --if-present
+      - run: dotnet r test
 
       - run: dotnet r pack
 

.gitignore

@@ -301,7 +301,7 @@ node_modules/
 *.dsw
 *.dsp
 
-# Visual Studio 6 technical files 
+# Visual Studio 6 technical files
 *.ncb
 *.aps
 
@@ -396,3 +396,6 @@ FodyWeavers.xsd
 
 # JetBrains Rider
 *.sln.iml
+
+# Verify snapshots
+*.received.*

Directory.Build.props

@@ -8,6 +8,11 @@
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 
+  <PropertyGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.1' ">
+    <EnableNETAnalyzers>true</EnableNETAnalyzers>
+    <AnalysisLevel>latest</AnalysisLevel>
+  </PropertyGroup>
+
   <PropertyGroup>
     <VersionPrefix>0.1.0</VersionPrefix>
     <Authors>Brian Surowiec</Authors>

analysis/idisposable.editorconfig

@@ -1,5 +1,6 @@
 is_global = true
 
+#
 # Rules
 
 # IDISP001: Dispose created

analysis/sdk.editorconfig

@@ -0,0 +1,34 @@
+is_global = true
+
+#
+# Rules
+
+# CA1062: Validate arguments of public methods
+dotnet_diagnostic.CA1062.severity = error
+
+# CA1303: Do not pass literals as localized parameters
+dotnet_diagnostic.CA1303.severity = error
+
+# CA1304: Specify CultureInfo
+dotnet_diagnostic.CA1304.severity = error
+
+# CA1305: Specify IFormatProvider
+dotnet_diagnostic.CA1305.severity = error
+
+# CA1307: Specify StringComparison for clarity
+dotnet_diagnostic.CA1307.severity = error
+
+# CA1308: Normalize strings to uppercase
+dotnet_diagnostic.CA1308.severity = error
+
+# CA1309: Use ordinal StringComparison
+dotnet_diagnostic.CA1309.severity = error
+
+# CA1310: Specify StringComparison for correctness
+dotnet_diagnostic.CA1310.severity = error
+
+# CA1838: Avoid StringBuilder parameters for P/Invokes
+dotnet_diagnostic.CA1838.severity = error
+
+# CA2101: Specify marshalling for P/Invoke string arguments
+dotnet_diagnostic.CA2101.severity = error

global.json

@@ -9,6 +9,9 @@
     "prebuild": "dotnet r clean",
     "build": "dotnet build",
     "test": "dotnet test --no-build --logger \"trx\" --results-directory \"./.coverage\"",
+    "test:31": "dotnet r test -- --framework netcoreapp3.1",
+    "test:5": "dotnet r test -- --framework net5.0",
+    "test:6": "dotnet r test -- --framework net6.0",
     "pack": "dotnet pack --no-build --output ./artifacts",
 
     "build:release": "dotnet r build -- --configuration Release",

run-script.sln

@@ -19,6 +19,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
 		README.md = README.md
 	EndProjectSection
 EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tests", "test\Tests.csproj", "{0A834097-CB5A-4E14-845D-1AA0E8EBEA29}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -29,6 +31,10 @@ Global
 		{AEF0FF86-3911-45DE-9291-EDC8E96329F4}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{AEF0FF86-3911-45DE-9291-EDC8E96329F4}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{AEF0FF86-3911-45DE-9291-EDC8E96329F4}.Release|Any CPU.Build.0 = Release|Any CPU
+		{0A834097-CB5A-4E14-845D-1AA0E8EBEA29}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{0A834097-CB5A-4E14-845D-1AA0E8EBEA29}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{0A834097-CB5A-4E14-845D-1AA0E8EBEA29}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{0A834097-CB5A-4E14-845D-1AA0E8EBEA29}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE