Skip to content

Adding a reaction with insufficient permissions doesn't throw an error or log a warning #604

@xt0rted

Description

@xt0rted

Depending on if the action is used on issues or pull requests the GITHUB_TOKEN or PAT needs issues: write or pull_requests: write permissions in order to add reactions. If the token doesn't have sufficient permission the code tries to add the reaction, and continues on even if it failed. This should at least check for the bad response and report an error but ideally it'd throw and not continue on.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions