Fix overload of abs for char type

serge-sans-paille · serge-sans-paille · commit 7933df6fb256 · 2024-04-19T17:30:30.000Z
diff --git a/include/xsimd/arch/xsimd_scalar.hpp b/include/xsimd/arch/xsimd_scalar.hpp
@@ -90,10 +90,24 @@ namespace xsimd
     {
         return v < 0 ? -v : v;
     }
+
+    namespace detail
+    {
+        inline char abs(char v, std::true_type)
+        {
+            return v;
+        }
+        inline char abs(char v, std::false_type)
+        {
+            return v < 0 ? -v : v;
+        }
+    }
+
     inline char abs(char v)
     {
-        return v < 0 ? -v : v;
+        return detail::abs(v, std::is_unsigned<char>::type {});
     }
+
     inline short abs(short v)
     {
         return v < 0 ? -v : v;

Original file line number	Diff line number	Diff line change
`@@ -90,10 +90,24 @@ namespace xsimd`
`90`	`90`	`{`
`91`	`91`	`return v < 0 ? -v : v;`
`92`	`92`	`}`
	`93`	`+`
	`94`	`+ namespace detail`
	`95`	`+ {`
	`96`	`+ inline char abs(char v, std::true_type)`
	`97`	`+ {`
	`98`	`+ return v;`
	`99`	`+ }`
	`100`	`+ inline char abs(char v, std::false_type)`
	`101`	`+ {`
	`102`	`+ return v < 0 ? -v : v;`
	`103`	`+ }`
	`104`	`+ }`
	`105`	`+`
`93`	`106`	`inline char abs(char v)`
`94`	`107`	`{`
`95`		`- return v < 0 ? -v : v;`
	`108`	`+ return detail::abs(v, std::is_unsigned<char>::type {});`
`96`	`109`	`}`
	`110`	`+`
`97`	`111`	`inline short abs(short v)`
`98`	`112`	`{`
`99`	`113`	`return v < 0 ? -v : v;`