Merge pull request #969 from xtensor-stack/feature/accurate-sincos

JohanMabille · web-flow · commit e9bd9798ab75 · 2023-11-10T04:09:40.000+01:00
Fix sincos implementation to cope with Emscripten
diff --git a/include/xsimd/arch/generic/xsimd_generic_math.hpp b/include/xsimd/arch/generic/xsimd_generic_math.hpp
@@ -974,12 +974,8 @@ namespace xsimd
         template <class A, class T>
         inline batch<std::complex<T>, A> polar(const batch<T, A>& r, const batch<T, A>& theta, requires_arch<generic>) noexcept
         {
-#ifndef EMSCRIPTEN
             auto sincosTheta = sincos(theta);
             return { r * sincosTheta.second, r * sincosTheta.first };
-#else
-            return { r * cos(theta), r * sin(theta) };
-#endif
         }
 
         // fdim

Original file line number	Diff line number	Diff line change
`@@ -974,12 +974,8 @@ namespace xsimd`
`974`	`974`	`template <class A, class T>`
`975`	`975`	`inline batch<std::complex<T>, A> polar(const batch<T, A>& r, const batch<T, A>& theta, requires_arch<generic>) noexcept`
`976`	`976`	`{`
`977`		`-#ifndef EMSCRIPTEN`
`978`	`977`	`auto sincosTheta = sincos(theta);`
`979`	`978`	`return { r * sincosTheta.second, r * sincosTheta.first };`
`980`		`-#else`
`981`		`- return { r * cos(theta), r * sin(theta) };`
`982`		`-#endif`
`983`	`979`	`}`
`984`	`980`
`985`	`981`	`// fdim`