Add tagfiles to support fetching documentation with xeus-cpp-lite #2862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thought of addressing before the pydata paris talk ;) Any kind of release would be helpful too |
|
Can you run pre-commit to fix the linter before I merge it? |
|
Addressed thanks for the review @JohanMabille |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We can currently fetch the standard documentation through xeus-cpp-lite. But we can't yet cover any 3rd party lib.
Xeus-cling could fetch xtensor documentation (even without xtensor being installed, because the tagfiles were added to xeus-cling themselves. Check here) . This doesn't sound justified.
As discussed with Sylvain in the past, we probably shouldn't populate xeus-cpp with the tagfiles for all repos but rather have them be a part of the repo itself. And then when we do a mamba install %xtensor, these end up in the file system and then can be put to use from there.
Something like