Skip to content

Commit 03ce26c

Browse files
committed
Questions, possible concern
1 parent cf6b868 commit 03ce26c

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/common/services/CoreMouseService.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ export class CoreMouseService extends Disposable implements ICoreMouseService {
177177
private _wheelPartialScroll: number = 0;
178178

179179
private readonly _onProtocolChange = this._register(new Emitter<CoreMouseEventType>());
180-
public readonly onProtocolChange = this._onProtocolChange.event;
180+
public readonly onProtocolChange = this._onProtocolChange.event;
181181

182182
constructor(
183183
@IBufferService private readonly _bufferService: IBufferService,
@@ -270,12 +270,16 @@ export class CoreMouseService extends Disposable implements ICoreMouseService {
270270

271271
private _applyScrollModifier(amount: number, ev: WheelEvent): number {
272272
const modifier = this._optionsService.rawOptions.fastScrollModifier; // QUESTION: This is always alt. Seems deprecated via: https://github.com/xtermjs/xterm.js/blob/5.5.0/src/browser/Viewport.ts
273-
console.log('what is this modifier: ', modifier);
273+
// Problem is that modifier always seem 'alt' even when ev.ctrlKey is true, for example.
274+
// Maybe this doesnt matter because all of alt, ctrl, shift does same operation?
274275

275276
// Multiply the scroll speed when the modifier key is pressed
276277
if ((modifier === 'alt' && ev.altKey) ||
277-
(modifier === 'ctrl' && ev.ctrlKey) ||
278-
(modifier === 'shift' && ev.shiftKey)) {
278+
(modifier === 'ctrl' && ev.ctrlKey) ||
279+
(modifier === 'shift' && ev.shiftKey)) {
280+
281+
console.log('fast scroll sensitivity: ', this._optionsService.rawOptions.fastScrollSensitivity);
282+
console.log('regular scroll sensitivity: ', this._optionsService.rawOptions.scrollSensitivity);
279283
return amount * this._optionsService.rawOptions.fastScrollSensitivity * this._optionsService.rawOptions.scrollSensitivity;
280284
}
281285

0 commit comments

Comments
 (0)