Skip to content

Commit bcdbb61

Browse files
authored
Merge pull request #4326 from Tyriar/166878
Fix NPE in webgl renderer
2 parents 880b726 + ea7571c commit bcdbb61

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

addons/xterm-addon-webgl/src/WebglRenderer.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ export class WebglRenderer extends Disposable implements IRenderer {
351351
let lastBg: number;
352352
let y: number;
353353
let row: number;
354-
let line: IBufferLine;
354+
let line: IBufferLine | undefined;
355355
let joinedRanges: [number, number][];
356356
let isJoined: boolean;
357357
let lastCharX: number;
@@ -364,7 +364,10 @@ export class WebglRenderer extends Disposable implements IRenderer {
364364

365365
for (y = start; y <= end; y++) {
366366
row = y + terminal.buffer.ydisp;
367-
line = terminal.buffer.lines.get(row)!;
367+
line = terminal.buffer.lines.get(row);
368+
if (!line) {
369+
break;
370+
}
368371
this._model.lineLengths[y] = 0;
369372
joinedRanges = this._characterJoinerService.getJoinedCharacters(row);
370373
for (x = 0; x < terminal.cols; x++) {

0 commit comments

Comments
 (0)