Skip to content

Commit a1c8ef9

Browse files
committed
change default for minVirtualenvVersion to 16 to avoid fails on environments created with the previous plugin versions
1 parent c84ef44 commit a1c8ef9

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

CHANGELOG.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
* Support python installation from Windows Store (#14)
2-
* Changed virtualenv version used by default from 16.7.9 to 20.4.2
2+
* Changed virtualenv version installed by default from 16.7.9 to 20.4.2
33
(because only recent versions could work correctly with python installed from Windows Store)
4-
* Add minimal required virtualenv check: by defautl it's virtualenv 20.0.11 (compatible with Windows Store python)
5-
Configured with python.minVirtualenvVersion. Important because v20 changes pip installation
6-
strategy in environment to the same version as bundled with virtualenv instead of always
7-
downloading new pip (extremely important for python 2 support because pip 21 does not support it anymore)
4+
* Add minimal required virtualenv check: by defautl it's virtualenv 16 (to not fail previously working environments).
5+
But it is recommended to use at least 20.0.11 (compatible with Windows Store python). V20 changes pip installation
6+
strategy in environment to the same version as bundled with virtualenv instead of always downloading new pip (which increase builds stability).
7+
Configured with python.minVirtualenvVersion.
88
* Fix up-to-date check in pipInstall task for VCS modules (the latest pip changed freeze output syntax)
99
* Hide passwords in logs for pip extra index repository urls with credentials (extraIndexUrls config) (#12)
1010
* Add general logged command cleaning mechanism to Python object for plugin authors (Pip object uses it for passwords hiding)

src/main/groovy/ru/vyarus/gradle/plugin/python/PythonExtension.groovy

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,17 +121,17 @@ class PythonExtension {
121121
*/
122122
String virtualenvVersion = '20.4.2'
123123
/**
124-
* Minimal required virtualenv version. It is important to use virtualenv 20 instead of 16 or older because
124+
* Minimal required virtualenv version. It is recommended to use virtualenv 20 instead of 16 or older because
125125
* it was a complete rewrite (and now it is stable enough). The most important moment is pip installation
126-
* behaviour: virtualenv <=15 was always downloading the latest pip which compromise build stability.
127-
* Moreover, pip 21 drops python 2 support, so using old virtualenv with it would always lead to
128-
* unusable environment.
126+
* behaviour: virtualenv <=16 was always downloading the latest pip which compromise build stability.
129127
* <p>
130-
* Used exact version 20.0.11 because it fixes Windows Store compatibility
131-
* (https://github.com/pypa/virtualenv/issues/1709). But specified version could actually have any precision:
132-
* e.g. '20' or '20.1'.
128+
* Default value set to 16 to not fail environments, created with the previous plugin versions. But it
129+
* is recommended to use at least 20.0.11 (because this version fixes Windows Store compatibility
130+
* (https://github.com/pypa/virtualenv/issues/1709)). Older virtualenvs could also be used!
131+
* <p>
132+
* Specified version could actually have any precision: '20', '20.1', etc.
133133
*/
134-
String minVirtualenvVersion = '20.0.11'
134+
String minVirtualenvVersion = '16'
135135
/**
136136
* Virtual environment path to use. Used only when {@link #scope} is configured to use virtualenv.
137137
* Virtualenv will be created automatically if not yet exists.

0 commit comments

Comments
 (0)