Reduce key length for MySQL

Author: SebastianStehle

Demo/Demo.csproj

@@ -6,8 +6,13 @@
     <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
 
+  <ItemGroup>
+    <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="8.0.11" />
+  </ItemGroup>
+
   <ItemGroup>
     <ProjectReference Include="..\YDotNet.Extensions\YDotNet.Extensions.csproj" />
+    <ProjectReference Include="..\YDotNet.Server.EntityFramework\YDotNet.Server.EntityFramework.csproj" />
     <ProjectReference Include="..\YDotNet.Server.MongoDB\YDotNet.Server.MongoDB.csproj" />
     <ProjectReference Include="..\YDotNet.Server.Redis\YDotNet.Server.Redis.csproj" />
     <ProjectReference Include="..\YDotNet.Server.WebSockets\YDotNet.Server.WebSockets.csproj" />

Directory.Build.props

@@ -11,7 +11,7 @@
     <PackageReadmeFile>README.md</PackageReadmeFile>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
-    <Version>0.4.2</Version>
+    <Version>0.4.3</Version>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">

Tests/YDotNet.Tests.Server.Unit/EFDocumentStorageMySqlFixture.cs

@@ -0,0 +1,80 @@
+namespace YDotNet.Tests.Server.Unit;
+
+using Microsoft.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore.Infrastructure;
+using Microsoft.EntityFrameworkCore.Storage;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Hosting;
+using NUnit.Framework;
+using Testcontainers.MySql;
+using YDotNet.Server.EntityFramework;
+using YDotNet.Server.Storage;
+
+[TestFixture]
+[Category("Docker")]
+public class EFDocumentStorageMySqlFixture : DocumentStorageTests
+{
+    private readonly MySqlContainer mysql = new MySqlBuilder().Build();
+    private IServiceProvider services;
+
+    public class AppDbContext(DbContextOptions options) : DbContext(options)
+    {
+        protected override void OnModelCreating(ModelBuilder modelBuilder)
+        {
+            modelBuilder.UseYDotNet();
+            base.OnModelCreating(modelBuilder);
+        }
+    }
+
+    [OneTimeSetUp]
+    public async Task OneTimeSetup()
+    {
+        await mysql.StartAsync();
+    }
+
+    [OneTimeTearDown]
+    public async Task OneTimeTeardown()
+    {
+        await mysql.StopAsync();
+    }
+
+    [SetUp]
+    public async Task Setup()
+    {
+        services = new ServiceCollection()
+            .AddLogging()
+            .AddDbContext<AppDbContext>(options =>
+            {
+                options.UseMySql(mysql.GetConnectionString(), ServerVersion.AutoDetect(mysql.GetConnectionString()));
+            })
+            .AddYDotNet()
+            .AddEntityFrameworkStorage<AppDbContext>()
+            .Services
+            .BuildServiceProvider();
+
+        foreach (var service in services.GetRequiredService<IEnumerable<IHostedService>>())
+        {
+            await service.StartAsync(default);
+        }
+
+        var factory = services.GetRequiredService<IDbContextFactory<AppDbContext>>();
+        var context = await factory.CreateDbContextAsync();
+        var creator = (RelationalDatabaseCreator)context.Database.GetService<IDatabaseCreator>();
+
+        await creator.EnsureCreatedAsync();
+    }
+
+    [TearDown]
+    public async Task Teardown()
+    {
+        foreach (var service in services.GetRequiredService<IEnumerable<IHostedService>>())
+        {
+            await service.StopAsync(default);
+        }
+    }
+
+    protected override IDocumentStorage CreateSut()
+    {
+        return services.GetRequiredService<IDocumentStorage>();
+    }
+}

….Server.Unit/EFDocumentStorageFixture.cs …Unit/EFDocumentStoragePostgresFixture.csTests/YDotNet.Tests.Server.Unit/EFDocumentStorageFixture.cs renamed to Tests/YDotNet.Tests.Server.Unit/EFDocumentStoragePostgresFixture.cs Tests/YDotNet.Tests.Server.Unit/EFDocumentStorageFixture.cs renamed to Tests/YDotNet.Tests.Server.Unit/EFDocumentStoragePostgresFixture.cs

@@ -1,4 +1,4 @@
-namespace YDotNet.Tests.Server.Unit;
+namespace YDotNet.Tests.Server.Unit;
 
 using Microsoft.EntityFrameworkCore;
 using Microsoft.EntityFrameworkCore.Infrastructure;
@@ -12,7 +12,7 @@ namespace YDotNet.Tests.Server.Unit;
 
 [TestFixture]
 [Category("Docker")]
-public class EFDocumentStorageFixture : DocumentStorageTests
+public class EFDocumentStoragePostgresFixture : DocumentStorageTests
 {
     private readonly PostgreSqlContainer postgres = new PostgreSqlBuilder().Build();
     private IServiceProvider services;

Tests/YDotNet.Tests.Server.Unit/YDotNet.Tests.Server.Unit.csproj

@@ -26,11 +26,13 @@
     <PackageReference Include="NUnit" Version="3.13.3" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.2.1" />
     <PackageReference Include="NUnit.Analyzers" Version="3.3.0" />
+    <PackageReference Include="Pomelo.EntityFrameworkCore.MySql" Version="8.0.2" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.435">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
     <PackageReference Include="Testcontainers.MongoDb" Version="4.1.0" />
+    <PackageReference Include="Testcontainers.MySql" Version="4.1.0" />
     <PackageReference Include="Testcontainers.PostgreSql" Version="4.1.0" />
   </ItemGroup>
 

YDotNet.Server.EntityFramework/ServiceExtensions.cs

@@ -32,7 +32,7 @@ public static ModelBuilder UseYDotNet(this ModelBuilder builder)
             b.HasKey(x => x.Id);
 
             b.Property(x => x.Id)
-                .HasMaxLength(1000);
+                .HasMaxLength(256);
         });
 
         return builder;