-
Notifications
You must be signed in to change notification settings - Fork 4
Description
Bug
Cause
clp-ffi-java internally use StandardCharsets.ISO_8859_1 in EncodedMessage.getLogTypeAsString();
clp-ffi-java/src/main/java/com/yscope/clp/compressorfrontend/EncodedMessage.java
Lines 30 to 36 in c4a74db
| public String getLogTypeAsString() { | |
| if (null == logtype) { | |
| return null; | |
| } else { | |
| return new String(logtype, StandardCharsets.ISO_8859_1); | |
| } | |
| } |
(
getDictionaryVarsAsStrings also)
Effect
This makes some characters broken like this:
Request processing failed: jakarta.validation.ConstraintViolationException: getAgentsList.from: /u0011 이상이어야 합니다
into
Request processing failed: jakarta.validation.ConstraintViolationException: getAgentsList.from: � ����� ���
This is fine after going through the decode function, but when dealing with individual logtype, these broken strings don't seem appropriate (LIKE searches, etc).
clp-ffi version
0.4.4
Environment
Linux, Java
https://github.com/apache/pinot/blob/1d490c1ac3268103a16d77ddfa70f8f8602f9e96/pom.xml#L160
Reproduction steps
Encode some characters which is not supported by ISO_8859_1
Request processing failed: jakarta.validation.ConstraintViolationException: getAgentsList.from: /u0011 이상이어야 합니다
Then get the logtype
Request processing failed: jakarta.validation.ConstraintViolationException: getAgentsList.from: � ����� ���