-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Description
Description
Remove unnecessary rvalue reference parameters (&&) from private constructors as they don't provide meaningful benefits for internal-only APIs.
Context
During PR review, it was noted that private constructors don't need the flexibility of rvalue references since they are only used internally. This applies to parameters like stream_reader_data_context in private constructors.
Examples
UnstructuredIrStreamReaderprivate constructorStructuredIrStreamReaderprivate constructor (if applicable)- Other similar cases in the codebase
References
- Discussion in PR feat: Add support for retrieving CLP IR stream-level metadata from IR stream readers (resolves #77). #80: feat: Add support for retrieving CLP IR stream-level metadata from IR stream readers (resolves #77). #80 (comment)
- Related comment: feat: Add support for retrieving CLP IR stream-level metadata from IR stream readers (resolves #77). #80 (comment)
Acceptance Criteria
- Identify all private constructors using rvalue references unnecessarily
- Remove
&&from private constructor parameters where not needed - Ensure all call sites still compile and work correctly
- Update any related documentation if necessary
Requested by: @junhaoliao
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels