feat(clp-s): Make lossless float retention the default behaviour for clp-s. (#1321)

Author: gibber9809

components/core/src/clp_s/CommandLineArguments.cpp

@@ -245,9 +245,9 @@ CommandLineArguments::parse_arguments(int argc, char const** argv) {
                     po::bool_switch(&m_print_archive_stats),
                     "Print statistics (json) about the archive after it's compressed."
             )(
-                    "retain-float-format",
-                    po::bool_switch(&m_retain_float_format),
-                    "Store extra information to losslessly decompress floats."
+                    "no-retain-float-format",
+                    po::bool_switch(&m_no_retain_float_format),
+                    "Do not store extra information to losslessly decompress floats."
             )(
                     "single-file-archive",
                     po::bool_switch(&m_single_file_archive),

components/core/src/clp_s/CommandLineArguments.hpp

@@ -102,7 +102,9 @@ class CommandLineArguments {
 
     OutputHandlerType get_output_handler_type() const { return m_output_handler_type; }
 
-    [[nodiscard]] bool get_retain_float_format() const { return m_retain_float_format; }
+    [[nodiscard]] auto get_retain_float_format() const -> bool {
+        return false == m_no_retain_float_format;
+    }
 
     bool get_single_file_archive() const { return m_single_file_archive; }
 
@@ -181,7 +183,7 @@ class CommandLineArguments {
     size_t m_target_encoded_size{8ULL * 1024 * 1024 * 1024};  // 8 GiB
     bool m_print_archive_stats{false};
     size_t m_max_document_size{512ULL * 1024 * 1024};  // 512 MB
-    bool m_retain_float_format{false};
+    bool m_no_retain_float_format{false};
     bool m_single_file_archive{false};
     bool m_structurize_arrays{false};
     bool m_ordered_decompression{false};

components/job-orchestration/job_orchestration/executor/compress/compression_task.py

@@ -290,7 +290,6 @@ def _make_clp_s_command_and_env(
         "--target-encoded-size",
         str(clp_config.output.target_segment_size + clp_config.output.target_dictionaries_size),
         "--compression-level", str(clp_config.output.compression_level),
-        "--retain-float-format",
     ]
     # fmt: on