fix(job-orchestration): Make tag_ids a required list[int] for compatibility with Spider compressor. (#1453)

Author: sitaowang1998

components/job-orchestration/job_orchestration/executor/compress/celery_compress.py

@@ -19,7 +19,7 @@ def compress(
     self: Task,
     job_id: int,
     task_id: int,
-    tag_ids,
+    tag_ids: list[int],
     clp_io_config_json: str,
     paths_to_compress_json: str,
     clp_metadata_db_connection_config,

components/job-orchestration/job_orchestration/executor/compress/compression_task.py

@@ -71,7 +71,7 @@ def update_tags(
     table_prefix: str,
     dataset: Optional[str],
     archive_id: str,
-    tag_ids: List[int],
+    tag_ids: list[int],
 ) -> None:
     db_cursor.executemany(
         f"""
@@ -87,10 +87,10 @@ def update_job_metadata_and_tags(
     job_id: int,
     table_prefix: str,
     dataset: Optional[str],
-    tag_ids: List[int],
+    tag_ids: list[int],
     archive_stats: Dict[str, Any],
 ) -> None:
-    if tag_ids is not None:
+    if len(tag_ids) > 0:
         update_tags(db_cursor, table_prefix, dataset, archive_stats["id"], tag_ids)
     increment_compression_job_metadata(
         db_cursor,
@@ -312,7 +312,7 @@ def run_clp(
     logs_dir: pathlib.Path,
     job_id: int,
     task_id: int,
-    tag_ids,
+    tag_ids: list[int],
     paths_to_compress: PathsToCompress,
     sql_adapter: SQL_Adapter,
     clp_metadata_db_connection_config,
@@ -522,7 +522,7 @@ def run_clp(
 def compression_entry_point(
     job_id: int,
     task_id: int,
-    tag_ids,
+    tag_ids: list[int],
     clp_io_config_json: str,
     paths_to_compress_json: str,
     clp_metadata_db_connection_config: Dict[str, Any],

components/job-orchestration/job_orchestration/scheduler/compress/compression_scheduler.py

@@ -342,7 +342,7 @@ def search_and_schedule_new_tasks(
         )
         db_conn.commit()
 
-        tag_ids = None
+        tag_ids = []
         if clp_io_config.output.tags:
             tags_table_name = get_tags_table_name(table_prefix, dataset)
             db_cursor.executemany(