Skip to content

Commit feceebc

Browse files
committed
Address review
1 parent 411a2f5 commit feceebc

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

taskfiles/deps/README.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,18 @@
22

33
Follow the guidelines below when writing or updating dependency installation taskfiles.
44

5-
- Use `deps:utils:install-remote-cmake-lib` and thus `yscope-dev-utils:cmake:install-remote-tar`
6-
whenever applicable.
5+
- Use one of the following tasks for installation, in descending order of preference:
6+
- `deps:utils:install-remote-cmake-lib`
7+
- `yscope-dev-utils:cmake:install-remote-tar`
78

8-
- For ones that don't apply:
9+
- For special tasks that don't apply to the rule above:
910
- Include `deps:utils:init` in the `deps:` section of the task.
1011
- Briefly explain why if the library is installable via CMake.
11-
- Verify that each library has proper checksum validation to check if it is up-to-date.
12+
- Ensure each library installation includes checksum validation using best effort.
13+
- Use of `yscope-dev-utils` tasks is encouraged, as most of them include proper checksum checks.
1214
- Use `<lib>-extracted` as the directory name for tarball extractions.
1315

14-
- Avoid parsing version numbers from download URLs unless the version is used elsewhere.
16+
- Avoid parsing version numbers in download URLs unless the version is used elsewhere.
1517
- URL formats can change over time, so it’s more maintainable to store and use the full URL
1618
directly as plain text.
1719

taskfiles/deps/main.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ tasks:
9393
preconditions:
9494
# NOTE: Spider is only supported on Ubuntu at present.
9595
- >-
96-
source /etc/os-release && [[ "$ID" == "ubuntu" ]]
96+
. /etc/os-release && [ "$ID" == "ubuntu" ]
9797
cmds:
9898
- task: "yscope-dev-utils:cmake:install-remote-tar"
9999
vars:

0 commit comments

Comments
 (0)