Skip to content

webui: typescript should not be needed in server runtime. #1116

@junhaoliao

Description

@junhaoliao

Bug

The package was found to include the typescript library in the server directory, unnecessarily increasing the package size by 23 MB.

junhao@GIGABYTE:~/Downloads/clp-text-x86_64-v0.4.0/var/www/webui/server/node_modules$ du -h | sort -h | grep typescript
4.0K    ./@typescript-eslint
8.0K    ./@fastify/autoload/test/typescript-esm/app
8.0K    ./@fastify/autoload/test/typescript-jest/babel-node
8.0K    ./@fastify/autoload/test/typescript-jest/basic/foo
12K     ./@fastify/autoload/test/typescript-jest/integration
12K     ./typescript/bin
16K     ./@fastify/autoload/test/typescript-common/basic/foo
16K     ./@fastify/autoload/test/typescript/basic/foo
20K     ./@fastify/autoload/test/typescript-esm
20K     ./@fastify/autoload/test/typescript-jest/basic
20K     ./socks/docs/examples/typescript
24K     ./@fastify/autoload/test/typescript-common/basic
24K     ./@fastify/autoload/test/typescript/basic
32K     ./@fastify/autoload/test/typescript
32K     ./@fastify/autoload/test/typescript-common
44K     ./@fastify/autoload/test/typescript-jest
288K    ./typescript/lib/zh-tw
292K    ./typescript/lib/zh-cn
316K    ./typescript/lib/cs
324K    ./typescript/lib/pt-br
324K    ./typescript/lib/tr
336K    ./typescript/lib/es
336K    ./typescript/lib/it
336K    ./typescript/lib/pl
340K    ./typescript/lib/de
340K    ./typescript/lib/fr
340K    ./typescript/lib/ko
376K    ./typescript/lib/ja
436K    ./typescript/lib/ru
22M     ./typescript/lib
23M     ./typescript

CLP version

8fc0dd7

Environment

Packaging issue which is unrelated to the runtime environment.

Reproduction steps

  1. Build the package: task
  2. cd build/clp-package/var/www/webui/server/node_modules
  3. ls -l | grep typescript

Actual: The typescript directory exists, which suggests it's installed as a runtime dependency and will be packaged in releases.
Expect: The typescript directory should not exist.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions