Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
06c7147
feat(core): Add support for musllinux_1_2
jackluo923 Jun 30, 2025
e4adcf6
Add docs.
jackluo923 Jun 30, 2025
889f97d
Update tag for arm64
jackluo923 Jul 1, 2025
4998cd6
Rename directory to match other platforms
jackluo923 Jul 1, 2025
9b14097
Merge branch 'main' into musllinux_1_2
jackluo923 Jul 3, 2025
4edace6
Addressed code-rabbit review points.
jackluo923 Jul 3, 2025
fb47ca2
Addressed code-rabbit review points.
jackluo923 Jul 6, 2025
55dc329
Merge branch 'main' into musllinux_1_2
jackluo923 Jul 6, 2025
6be8932
Update components/core/tools/scripts/lib_install/musllinux_1_2/instal…
jackluo923 Jul 7, 2025
1112b85
Update components/core/tools/scripts/lib_install/musllinux_1_2/instal…
jackluo923 Jul 7, 2025
3c06cbf
Update docs/src/dev-guide/tooling-containers.md
jackluo923 Jul 7, 2025
56d3b92
Update components/core/tools/docker-images/clp-env-base-musllinux_1_2…
jackluo923 Jul 7, 2025
bedf84e
Removed comment regarding image flattening warning.
jackluo923 Jul 7, 2025
7b29331
Updated the docs related to the version of dependency task is install…
jackluo923 Jul 7, 2025
d34b315
Typo in comments in install-package-from-source.sh
jackluo923 Jul 7, 2025
c2c4a31
Update components/core/tools/docker-images/clp-env-base-musllinux_1_2…
jackluo923 Jul 7, 2025
5eea5f1
Merge branch 'main' into musllinux_1_2
jackluo923 Jul 9, 2025
987104c
Upgraded spdlog to 1.14.1, the latest version
jackluo923 Jul 11, 2025
8d2ed5d
Merge branch 'main' into musllinux_1_2
jackluo923 Jul 11, 2025
873b9dc
Update doc.
jackluo923 Jul 11, 2025
33d85e5
Resolve more code review issues.
jackluo923 Jul 12, 2025
2980a94
Merge branch 'main' into musllinux_1_2
jackluo923 Jul 14, 2025
6d9286b
Merge branch 'main' into musllinux_1_2
LinZhihao-723 Jul 14, 2025
d3a7817
Merge branch 'main' into musllinux_1_2
jackluo923 Jul 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/core/src/clp/SQLitePreparedStatement.hpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#ifndef CLP_SQLITEPREPAREDSTATEMENT_HPP
#define CLP_SQLITEPREPAREDSTATEMENT_HPP

#include <cstdint>
#include <string>

#include <sqlite3/sqlite3.h>
Expand Down
1 change: 1 addition & 0 deletions components/core/src/clp_s/Utils.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#include <array>
#include <charconv>
#include <cstdint>
#include <cstring>
#include <sstream>
#include <string>
Expand Down
1 change: 1 addition & 0 deletions components/core/src/glt/SQLitePreparedStatement.hpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#ifndef GLT_SQLITEPREPAREDSTATEMENT_HPP
#define GLT_SQLITEPREPAREDSTATEMENT_HPP

#include <cstdint>
#include <string>

#include <sqlite3/sqlite3.h>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
FROM quay.io/pypa/musllinux_1_2_aarch64

WORKDIR /root

RUN mkdir -p ./tools/scripts/lib_install
COPY ./tools/scripts/lib_install ./tools/scripts/lib_install

RUN ./tools/scripts/lib_install/musllinux_1_2/install-all.sh

# Remove cached files
RUN apk cache clean && rm -rf /var/cache/apk/* /tmp/* /var/tmp/*

Copy link
Contributor

@coderabbitai coderabbitai bot Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Leverage --no-cache instead of manual cache purging
Running apk update/apk add in the downstream scripts will repopulate /var/cache/apk. Using apk add --no-cache (and omitting apk update) avoids creating the cache in the first place and eliminates the need for apk cache clean && rm -rf /var/cache/apk/*.
This yields smaller layers and faster builds.

🤖 Prompt for AI Agents
In
components/core/tools/docker-images/clp-env-base-musllinux_1_2-aarch64/Dockerfile
around lines 10 to 12, the Dockerfile manually cleans the apk cache after
package installation. Instead, modify the apk package installation commands to
use the --no-cache option, which prevents cache creation during installation.
Remove the explicit apk cache clean and rm -rf commands since they become
unnecessary, resulting in smaller image layers and faster builds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added --no-cache to install-prebuilt-packages.sh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

@jackluo923 Great! I can see that --no-cache has been added to the apk add command. Since the package installation now uses --no-cache, the manual cache cleanup in the Dockerfile on line 10-11 is no longer necessary:

# This can be removed since --no-cache prevents cache creation
RUN apk cache clean && rm -rf /var/cache/apk/* /tmp/* /var/tmp/*

You can remove that RUN command entirely, which will result in:

  • Smaller image layers
  • Faster builds
  • Cleaner Dockerfile

The same optimization can be applied to the x86_64 variant as well.


🏁 Script executed:

# Check if --no-cache flag has been added to install-prebuilt-packages.sh
cat components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh | grep -n "apk"

Length of output: 131


@jackluo923 I can see from the script output that the install-prebuilt-packages.sh file still shows apk update && apk add on line 6, which suggests the --no-cache flag hasn't been applied yet.

To properly implement the --no-cache optimization, you'll need to:

  1. In install-prebuilt-packages.sh: Replace apk update && apk add with apk add --no-cache
  2. In the Dockerfile: Remove the manual cache cleanup line RUN apk cache clean && rm -rf /var/cache/apk/* /tmp/* /var/tmp/*

This change should be applied to both the aarch64 and x86_64 variants for consistency.


🏁 Script executed:

# Get the full content of install-prebuilt-packages.sh to see the current state
cat components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh

Length of output: 940


@jackluo923 I can see the current state of the install-prebuilt-packages.sh file. The --no-cache flag hasn't been added yet. Here's how to properly implement the optimization:

1. In install-prebuilt-packages.sh, change line 6 from:

apk update &&  apk add \

To:

apk add --no-cache \

2. In the Dockerfile, remove line 10-11:

# Remove cached files
RUN apk cache clean && rm -rf /var/cache/apk/* /tmp/* /var/tmp/*

This optimization works because:

  • --no-cache prevents the package cache from being created in the first place
  • No apk update is needed when using --no-cache (it updates the index automatically)
  • Manual cache cleanup becomes unnecessary

Don't forget to apply the same changes to the x86_64 variant for consistency!


🧠 Learnings used
Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/docker-images/clp-env-base-musllinux_1_2-x86/build.sh:18-24
Timestamp: 2025-07-01T14:52:02.418Z
Learning: In the CLP project, consistency across platform build scripts is prioritized over defensive programming when it comes to git remote handling. All build.sh files in docker-images directories should follow the same pattern for git metadata injection.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/docker-images/clp-env-base-musllinux_1_2-x86/build.sh:18-24
Timestamp: 2025-07-01T14:52:02.418Z
Learning: In the CLP project, consistency across platform build scripts is prioritized over defensive programming when it comes to git remote handling. All build.sh files in docker-images directories should follow the same pattern for git metadata injection.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh:6-15
Timestamp: 2025-07-01T14:52:15.217Z
Learning: For installation scripts in the CLP project, maintain consistency in command patterns across platforms rather than applying platform-specific optimizations. When a platform follows a pattern of separate update and install commands (like `apt-get update && apt-get install` or `apk update && apk add`), preserve this pattern for uniform script structure.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh:6-15
Timestamp: 2025-07-01T14:52:15.217Z
Learning: For installation scripts in the CLP project, maintain consistency in command patterns across platforms rather than applying platform-specific optimizations. When a platform follows a pattern of separate update and install commands (like `apt-get update && apt-get install` or `apk update && apk add`), preserve this pattern for uniform script structure.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh:6-15
Timestamp: 2025-07-01T14:52:15.217Z
Learning: For installation scripts in the CLP project, maintain consistency in command patterns across platforms rather than applying platform-specific optimizations. When a platform follows a pattern of separate update and install commands (like `apt-get update && apt-get install` or `apk update && apk add`), preserve this pattern for uniform script structure.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh:6-15
Timestamp: 2025-07-01T14:52:15.217Z
Learning: For installation scripts in the CLP project, maintain consistency in command patterns across different platforms (e.g., using separate update and install commands like `apk update && apk add`, `apt update && apt install`, `yum update && yum install`) rather than platform-specific optimizations, to ensure uniform script structure and readability.

Learnt from: quinntaylormitchell
PR: y-scope/clp#918
File: .github/workflows/clp-execution-image-build.yaml:77-97
Timestamp: 2025-05-26T16:03:05.519Z
Learning: In .github/workflows/clp-execution-image-build.yaml, the ubuntu-jammy-execution-image and ubuntu-noble-execution-image jobs are intentionally kept separate (rather than using a matrix strategy) to make it easier to remove individual platform versions when they reach end of life, such as when jammy eventually becomes obsolete.

Learnt from: kirkrodrigues
PR: y-scope/clp#881
File: components/core/tools/scripts/lib_install/ubuntu-jammy/install-prebuilt-packages.sh:35-41
Timestamp: 2025-05-06T09:48:55.408Z
Learning: For installation scripts in the CLP project, prefer explicit error handling over automatic dependency resolution (like `apt-get install -f`) when installing packages to give users more control over their system.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-packages-from-source.sh:6-8
Timestamp: 2025-07-01T14:51:19.172Z
Learning: In CLP installation scripts within `components/core/tools/scripts/lib_install/`, maintain consistency with existing variable declaration patterns across platforms rather than adding individual improvements like `readonly` declarations.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-packages-from-source.sh:6-8
Timestamp: 2025-07-01T14:51:19.172Z
Learning: In CLP installation scripts within `components/core/tools/scripts/lib_install/`, maintain consistency with existing variable declaration patterns across platforms rather than adding individual improvements like `readonly` declarations.

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

# NOTE: Don't flatten the image or else we'll lose any environment modifications from the base
# image.
Copy link
Contributor

@coderabbitai coderabbitai bot Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Consider adding a non-root user and a HEALTHCHECK for defence-in-depth
Musllinux images run as root by default. If this image is ever used in production (or as a base for production images), switching to a non-root user and defining a simple HEALTHCHECK can improve security and observability without major overhead.

🧰 Tools
🪛 Checkov (3.2.334)

[LOW] 1-1: Ensure the base image uses a non latest version tag

(CKV_DOCKER_7)


[LOW] 1-14: Ensure that HEALTHCHECK instructions have been added to container images

(CKV_DOCKER_2)


[LOW] 1-14: Ensure that a user for the container has been created

(CKV_DOCKER_3)

🪛 Hadolint (2.12.0)

[warning] 1-1: Always tag the version of an image explicitly

(DL3006)

🤖 Prompt for AI Agents
In
components/core/tools/docker-images/clp-env-base-musllinux_1_2-aarch64/Dockerfile
lines 1 to 14, the image runs as root by default which poses security risks. Add
a non-root user and switch to that user after setup steps to enhance security.
Also, define a simple HEALTHCHECK instruction to monitor container health and
improve observability. Ensure the user has necessary permissions for the
installed files and scripts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NA

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackluo923 Understood, I'll note that these security suggestions are not applicable for this Dockerfile. Moving on.


🧠 Learnings used
Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/docker-images/clp-env-base-musllinux_1_2-x86/build.sh:18-24
Timestamp: 2025-07-01T14:52:02.418Z
Learning: In the CLP project, consistency across platform build scripts is prioritized over defensive programming when it comes to git remote handling. All build.sh files in docker-images directories should follow the same pattern for git metadata injection.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/docker-images/clp-env-base-musllinux_1_2-x86/build.sh:18-24
Timestamp: 2025-07-01T14:52:02.418Z
Learning: In the CLP project, consistency across platform build scripts is prioritized over defensive programming when it comes to git remote handling. All build.sh files in docker-images directories should follow the same pattern for git metadata injection.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh:6-15
Timestamp: 2025-07-01T14:52:15.217Z
Learning: For installation scripts in the CLP project, maintain consistency in command patterns across platforms rather than applying platform-specific optimizations. When a platform follows a pattern of separate update and install commands (like `apt-get update && apt-get install` or `apk update && apk add`), preserve this pattern for uniform script structure.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh:6-15
Timestamp: 2025-07-01T14:52:15.217Z
Learning: For installation scripts in the CLP project, maintain consistency in command patterns across platforms rather than applying platform-specific optimizations. When a platform follows a pattern of separate update and install commands (like `apt-get update && apt-get install` or `apk update && apk add`), preserve this pattern for uniform script structure.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh:6-15
Timestamp: 2025-07-01T14:52:15.217Z
Learning: For installation scripts in the CLP project, maintain consistency in command patterns across platforms rather than applying platform-specific optimizations. When a platform follows a pattern of separate update and install commands (like `apt-get update && apt-get install` or `apk update && apk add`), preserve this pattern for uniform script structure.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh:6-15
Timestamp: 2025-07-01T14:52:15.217Z
Learning: For installation scripts in the CLP project, maintain consistency in command patterns across different platforms (e.g., using separate update and install commands like `apk update && apk add`, `apt update && apt install`, `yum update && yum install`) rather than platform-specific optimizations, to ensure uniform script structure and readability.

Learnt from: quinntaylormitchell
PR: y-scope/clp#918
File: .github/workflows/clp-execution-image-build.yaml:77-97
Timestamp: 2025-05-26T16:03:05.519Z
Learning: In .github/workflows/clp-execution-image-build.yaml, the ubuntu-jammy-execution-image and ubuntu-noble-execution-image jobs are intentionally kept separate (rather than using a matrix strategy) to make it easier to remove individual platform versions when they reach end of life, such as when jammy eventually becomes obsolete.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-packages-from-source.sh:6-8
Timestamp: 2025-07-01T14:51:19.172Z
Learning: In CLP installation scripts within `components/core/tools/scripts/lib_install/`, maintain consistency with existing variable declaration patterns across platforms rather than adding individual improvements like `readonly` declarations.

Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-packages-from-source.sh:6-8
Timestamp: 2025-07-01T14:51:19.172Z
Learning: In CLP installation scripts within `components/core/tools/scripts/lib_install/`, maintain consistency with existing variable declaration patterns across platforms rather than adding individual improvements like `readonly` declarations.

Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#!/usr/bin/env bash

set -eu
set -o pipefail

script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
component_root="${script_dir}/../../../"

build_cmd=(
docker buildx build
--platform linux/arm64
--tag clp-core-dependencies-arm64-musllinux_1_2:dev
"$component_root"
--file "${script_dir}/Dockerfile"
--load
)

if command -v git >/dev/null && git -C "$script_dir" rev-parse --is-inside-work-tree >/dev/null ;
then
build_cmd+=(
--label "org.opencontainers.image.revision=$(git -C "$script_dir" rev-parse HEAD)"
--label "org.opencontainers.image.source=$(git -C "$script_dir" remote get-url origin)"
)
fi

echo "Running: ${build_cmd[*]}"
"${build_cmd[@]}"
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
FROM quay.io/pypa/musllinux_1_2_x86_64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Pin the base image to a digest to ensure reproducible builds

Relying solely on the tag quay.io/pypa/musllinux_1_2_x86_64 exposes the build to silent upstream changes.
Fetch the image digest (docker pull --quiet …; docker inspect --format='{{index .RepoDigests 0}}' …) and reference it:

-FROM quay.io/pypa/musllinux_1_2_x86_64
+FROM quay.io/pypa/musllinux_1_2_x86_64@sha256:<digest>

This satisfies CKV_DOCKER_7 / DL3006 and guarantees bit-for-bit identical layers.

🧰 Tools
🪛 Checkov (3.2.334)

[LOW] 1-1: Ensure the base image uses a non latest version tag

(CKV_DOCKER_7)


[LOW] 1-14: Ensure that HEALTHCHECK instructions have been added to container images

(CKV_DOCKER_2)


[LOW] 1-14: Ensure that a user for the container has been created

(CKV_DOCKER_3)

🪛 Hadolint (2.12.0)

[warning] 1-1: Always tag the version of an image explicitly

(DL3006)

🤖 Prompt for AI Agents
In components/core/tools/docker-images/clp-env-base-musllinux_1_2-x86/Dockerfile
at line 1, the base image is referenced by tag only, which can lead to
non-reproducible builds due to upstream changes. To fix this, pull the image
locally, retrieve its digest using docker inspect, and update the FROM line to
use the image digest instead of the tag. This pins the base image to a specific
immutable version, ensuring consistent and reproducible builds.


WORKDIR /root

RUN mkdir -p ./tools/scripts/lib_install
COPY ./tools/scripts/lib_install ./tools/scripts/lib_install

RUN ./tools/scripts/lib_install/musllinux_1_2/install-all.sh

# Remove cached files
RUN apk cache clean && rm -rf /var/cache/apk/* /tmp/* /var/tmp/*

# NOTE: Don't flatten the image or else we'll lose any environment modifications from the base
# image.
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#!/usr/bin/env bash

set -eu
set -o pipefail

script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
component_root="${script_dir}/../../../"

build_cmd=(
docker buildx build
--platform linux/amd64
--tag clp-core-dependencies-x86-musllinux_1_2:dev
"$component_root"
--file "${script_dir}/Dockerfile"
--load
)

if command -v git >/dev/null && git -C "$script_dir" rev-parse --is-inside-work-tree >/dev/null ;
then
build_cmd+=(
--label "org.opencontainers.image.revision=$(git -C "$script_dir" rev-parse HEAD)"
--label "org.opencontainers.image.source=$(git -C "$script_dir" remote get-url origin)"
)
fi

echo "Running: ${build_cmd[*]}"
"${build_cmd[@]}"
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/usr/bin/env bash

set -eu
set -o pipefail

script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"

"${script_dir}/install-prebuilt-packages.sh"
"${script_dir}/install-packages-from-source.sh"

# TODO: https://github.com/y-scope/clp/issues/795
"${script_dir}/../check-cmake-version.sh"
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
#!/usr/bin/env bash

set -eu
set -o pipefail

script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
lib_install_scripts_dir="${script_dir}/.."

# NOTE: The remaining installation scripts depend on boost, so we install it beforehand.
"${lib_install_scripts_dir}/install-boost.sh" 1.87.0

# NOTE:
# 1. libarchive may statically link with LZMA, LZ4, and Zstandard, so we install them beforehand.
# 2. The versions of libarchive, LZMA, LZ4, and Zstandard available in manylinux_2_28's package
# repositories are either dated or don't include static libraries, so we install more recent
# versions from source.
"${lib_install_scripts_dir}/liblzma.sh" 5.8.1
"${lib_install_scripts_dir}/lz4.sh" 1.10.0
"${lib_install_scripts_dir}/zstandard.sh" 1.5.7
"${lib_install_scripts_dir}/libarchive.sh" 3.8.0

"${lib_install_scripts_dir}/msgpack.sh" 7.0.0
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
#!/usr/bin/env bash

set -eu
set -o pipefail

apk update && apk add \
openjdk11-jdk \
jq \
curl-dev \
bzip2-dev \
bzip2-static \
mariadb-connector-c-dev \
openssl-dev \
zlib-dev \
zlib-static

# Install `task`
# NOTE: We lock `task` to a version < 3.43 to avoid https://github.com/y-scope/clp/issues/
VERSION=3.42.1
ARCH=$(uname -m)
case "$ARCH" in
x86_64) ARCH=amd64 ;;
aarch64) ARCH=arm64 ;;
*) echo "Unsupported architecture: $ARCH"; exit 1 ;;
esac

wget -O /tmp/task.tar.gz \
"https://github.com/go-task/task/releases/download/v${VERSION}/task_linux_${ARCH}.tar.gz"

tar -C /usr/local/bin -xzf /tmp/task.tar.gz task
chmod +x /usr/local/bin/task
rm /tmp/task.tar.gz

# Downgrade to CMake v3 to work around https://github.com/y-scope/clp/issues/795
pipx uninstall cmake
pipx install cmake~=3.31
8 changes: 4 additions & 4 deletions taskfiles/deps/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,8 @@ tasks:
- "-DFMT_DOC=OFF"
- "-DFMT_TEST=OFF"
LIB_NAME: "{{.G_FMT_LIB_NAME}}"
TARBALL_SHA256: "b06ca3130158c625848f3fb7418f235155a4d389b2abc3a6245fb01cb0eb1e01"
TARBALL_URL: "https://github.com/fmtlib/fmt/archive/refs/tags/8.0.1.tar.gz"
TARBALL_SHA256: "ede1b6b42188163a3f2e0f25ad5c0637eca564bd8df74d02e31a311dd6b37ad8"
TARBALL_URL: "https://github.com/fmtlib/fmt/archive/refs/tags/10.0.0.tar.gz"

log-surgeon:
internal: true
Expand Down Expand Up @@ -302,11 +302,11 @@ tasks:
- "-DSPDLOG_BUILD_EXAMPLE_HO=OFF"
- "-DSPDLOG_FMT_EXTERNAL=ON"
LIB_NAME: "spdlog"
TARBALL_SHA256: "6fff9215f5cb81760be4cc16d033526d1080427d236e86d70bb02994f85e3d38"
TARBALL_SHA256: "4dccf2d10f410c1e2feaff89966bfc49a1abb29ef6f08246335b110e001e09a9"

# NOTE: Since spdlog depends on fmt, we need to choose a version of spdlog that's
# compatible with the version of fmt we use.
TARBALL_URL: "https://github.com/gabime/spdlog/archive/refs/tags/v1.9.2.tar.gz"
TARBALL_URL: "https://github.com/gabime/spdlog/archive/refs/tags/v1.12.0.tar.gz"

sqlite3:
internal: true
Expand Down
Loading