-
Notifications
You must be signed in to change notification settings - Fork 83
build(deps): Bump yscope-dev-utils to the newest version:
#1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
bdc17df
5381afb
e7412eb
918a3a5
2baca84
b1fe7e5
71e670f
5b1f9ed
a4c3506
bb8348e
c05b152
cb94a12
fa0db54
dc4b1ea
63ed21a
b2b7a93
3220afd
afc267e
0606b6a
f31a2d9
11654f2
165e068
d0d4830
d767d73
49ee60c
f5c217a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -355,11 +355,11 @@ jobs: | |
| use_published_image: >- | ||
| ${{needs.filter-relevant-changes.outputs.ubuntu_jammy_image_changed == 'false' | ||
| || (github.event_name != 'pull_request' && github.ref == 'refs/heads/main')}} | ||
| # TODO: When enough files are passing clang-tidy, switch to a full pass on schedule only. | ||
| # run_command: >- | ||
| # task lint:check-cpp-${{(github.event_name == 'schedule') && 'full' || 'diff'}} | ||
| # TODO: We set HOME due to permission issues inside the container used in run-on-image. | ||
| # See: https://github.com/y-scope/clp/issues/1145 | ||
| run_command: >- | ||
| CLP_CORE_MAX_PARALLELISM_PER_BUILD_TASK=$(getconf _NPROCESSORS_ONLN) | ||
| HOME=/tmp | ||
| task lint:check-cpp-full | ||
|
Comment on lines
+358
to
363
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Variable assignments are now passed correctly; minor readability nit With the folded scalar ( To make this behaviour obvious to future readers you could keep everything on one physical line (or use the back-slash style used elsewhere): - CLP_CORE_MAX_PARALLELISM_PER_BUILD_TASK=$(getconf _NPROCESSORS_ONLN)
- HOME=/tmp
- task lint:check-cpp-full
+ CLP_CORE_MAX_PARALLELISM_PER_BUILD_TASK=$(getconf _NPROCESSORS_ONLN) \
+ HOME=/tmp \
+ task lint:check-cpp-fullPure style preference – no functional change.
🤖 Prompt for AI Agents |
||
|
|
||
| # Cache the source file checksums and the generated files (logs) for the | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| .clang-format | ||
| .clang-tidy | ||
| .lint-venv/ | ||
| .task/ | ||
| build/ | ||
| **/dist/ | ||
| dist/ |
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.