-
Notifications
You must be signed in to change notification settings - Fork 83
build(deps): Add task-based installations for LZ4 and Zstandard dependencies; Use latest versions for source-based installations. #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Bill-hbrhbr
merged 16 commits into
y-scope:main
from
Bill-hbrhbr:modernize-lz4-zstd-install
Aug 11, 2025
Merged
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9b862bb
Remove lz4 installations
Bill-hbrhbr 2df11f3
Install LZ4 via task and update docs and find module scripts
Bill-hbrhbr 982ff31
Use LZ4 built-in cmake find package moodule
Bill-hbrhbr 5835dbc
Temporarily test lz4
Bill-hbrhbr ac3292d
Revert "Temporarily test lz4"
Bill-hbrhbr fc2b711
Migrate zstandard to task
Bill-hbrhbr 48fd88d
misc fix
Bill-hbrhbr 47a2b18
Fix macos package selection with find package hints. Add missing link…
Bill-hbrhbr 4ec9c70
Use variable instead of library target for multiplexing lz4 and zstd …
Bill-hbrhbr cbd83cd
Merge branch 'main' into modernize-lz4-zstd-install
Bill-hbrhbr 7dc87e9
Put back zstd guard and remove superfluous zstd linkage
Bill-hbrhbr ea50989
Put back lz4 and zstd installations for now since libarchive cannot s…
Bill-hbrhbr 434177b
Merge branch 'main' into modernize-lz4-zstd-install
Bill-hbrhbr 60b2770
Merge branch 'main' into modernize-lz4-zstd-install
Bill-hbrhbr 85e2e53
Apply suggestions from code review
Bill-hbrhbr a7c2b63
Address review concern
Bill-hbrhbr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,5 +54,6 @@ if(CLP_BUILD_CLP_S_SEARCH) | |
| clp_s::clp_dependencies | ||
| clp_s::io | ||
| spdlog::spdlog | ||
| zstd_TARGET | ||
| ) | ||
| endif() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.