Skip to content

Commit 5b29dca

Browse files
committed
Address comments
1 parent 08cf54e commit 5b29dca

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

presto-clp/src/main/java/com/facebook/presto/plugin/clp/ClpExpression.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
/**
2121
* Represents the result of converting a Presto RowExpression into a CLP-compatible KQL query and
22-
* a SQL query for filtering splits by metadata database. In every case, `pushDownExpression`
22+
* a SQL query for filtering splits using a metadata database. In every case, `pushDownExpression`
2323
* represents the part of the RowExpression that could be converted to a KQL expression, and
2424
* `remainingExpression` represents the part that could not be converted.
2525
*/

presto-clp/src/main/java/com/facebook/presto/plugin/clp/ClpMetadataFilterProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ private Set<String> getRequiredColumnNamesFromFilters(List<Filter> filters)
212212

213213
private Map<String, RangeMapping> getAllMappingsFromFilters(List<Filter> filters)
214214
{
215-
return filters != null
215+
return null != filters
216216
? filters.stream()
217217
.filter(filter -> null != filter.rangeMapping)
218218
.collect(toImmutableMap(

presto-docs/src/main/sphinx/connector/clp.rst

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,13 +121,11 @@ Each *filter* includes:
121121

122122
- ``columnName``: must match a column name in the table’s schema.
123123

124-
.. note::
125-
Only numeric-type columns can currently be used as metadata filters.
124+
**Note:** Only numeric-type columns can currently be used as metadata filters.
126125

127126
- ``rangeMapping`` *(optional)*: specifies how the filter should be remapped when it targets metadata-only columns.
128127

129-
.. note::
130-
This option is only valid if the column is numeric type.
128+
**Note:** This option is only valid if the column is numeric type.
131129

132130
For example, a condition like:
133131

@@ -180,6 +178,7 @@ Explanation:
180178
- ``"clp"``: Adds a filter on the column ``level`` for all schemas and tables under the ``clp`` catalog.
181179
- ``"clp.default"``: Adds a filter on ``author`` for all tables under the ``clp.default`` schema.
182180
- ``"clp.default.table_1"``: Adds two filters for the table ``clp.default.table_1``:
181+
183182
- ``msg.timestamp`` is remapped via ``rangeMapping`` and is marked as **required**.
184183
- ``file_name`` is used as-is without remapping.
185184

0 commit comments

Comments
 (0)