Apply suggestions from code review

Co-authored-by: kirkrodrigues <[email protected]>

Author: anlowee

.github/workflows/maven-checks.yml

@@ -46,28 +46,31 @@ jobs:
         run: |
           export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
           ./mvnw install -B -V -T 1C -DskipTests -Dmaven.javadoc.skip=true --no-transfer-progress -P ci -pl '!presto-test-coverage,!:presto-docs'
-      - name: Upload presto-server tarball
+      - name: Upload presto-server
         if: matrix.java == '8.0.442'
         uses: actions/upload-artifact@v4
         with:
           name: presto-server
           path: presto-server/target/presto-server-0.293.tar.gz
-      - name: Upload presto-cli executable
+          if-no-files-found: "error"
+          retention-days: 1
+      - name: Upload presto-cli
         if: matrix.java == '8.0.442'
         uses: actions/upload-artifact@v4
         with:
           name: presto-cli
           path: presto-cli/target/presto-cli-0.293-executable.jar
+          if-no-files-found: "error"
+          retention-days: 1
       - name: Clean Maven Output
         run: ./mvnw clean -pl '!:presto-server,!:presto-cli,!presto-test-coverage'
-  
   presto-coordinator-with-clp-connector-runtime-image:
     name: presto-coordinator-runtime-image
     needs: maven-checks
     runs-on: ubuntu-22.04
     if: ${{ always() && success() }}
     steps:
-      - uses: "actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683"
+      - uses: "actions/checkout@v4"
         with:
           submodules: "recursive"
 
@@ -84,27 +87,27 @@ jobs:
           path: ./docker
 
       - name: "Login to image registry"
-        uses: "docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772"
+        uses: "docker/login-action@v3"
         with:
           registry: ghcr.io
           username: ${{github.actor}}
           password: ${{secrets.GITHUB_TOKEN}}
 
-      - name: "Update Metadata"
+      - name: "Set up container image metadata"
         id: "meta"
-        uses: "docker/metadata-action@902fa8ec7d6ecbf8d84d538b9b233a880e428804"
+        uses: "docker/metadata-action@v5"
         with:
           images: >-
-            ghcr.io/${{github.repository}}/coordinator-with-clp-connector-runtime
-          tags: |
-            type=raw,value=centos9
+            ghcr.io/${{github.repository}}/coordinator
+          tags: |-
+            type=raw,value=dev
 
       - name: "Build and push"
-        uses: "docker/build-push-action@471d1dc4e07e5cdedd4c2171150001c434f0b7a4"
+        uses: "docker/build-push-action@v6"
         with:
           build-args: |-
-            PRESTO_VERSION=0.293
             JMX_PROMETHEUS_JAVA_AGENT_VERSION=0.20.0
+            PRESTO_VERSION=0.293
           context: "./docker/"
           file: "./docker/Dockerfile"
           push: >-

.github/workflows/prestocpp-worker-with-clp-connector-runtime-image-build.yml

@@ -14,30 +14,30 @@ jobs:
         with:
           submodules: "recursive"
 
-      - name: "Login to Image Registry"
+      - name: "Login to image registry"
         uses: "docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772"
         with:
           registry: ghcr.io
           username: ${{github.actor}}
           password: ${{secrets.GITHUB_TOKEN}}
 
-      - name: "Update Metadata for Dependency Image"
+      - name: "Set up metadata for dependency image"
         id: "meta-dependency"
         uses: "docker/metadata-action@902fa8ec7d6ecbf8d84d538b9b233a880e428804"
         with:
           images: >-
-            ghcr.io/${{github.repository}}/prestissimo-with-clp-connector-dependency
-          tags: |
-            type=raw,value=ubuntu-22.04
+            ghcr.io/${{github.repository}}/prestissimo-worker-dev-env
+          tags: |-
+            type=raw,value=dev
 
-      - name: "Update Metadata for Runtime Image"
+      - name: "Set up metadata for runtime image"
         id: "meta-runtime"
         uses: "docker/metadata-action@902fa8ec7d6ecbf8d84d538b9b233a880e428804"
         with:
           images: >-
-            ghcr.io/${{github.repository}}/prestissimo-with-clp-connector-runtime
-          tags: |
-            type=raw,value=ubuntu-22.04
+            ghcr.io/${{github.repository}}/prestissimo-worker
+          tags: |-
+            type=raw,value=dev
 
       - name: Check for dependency changes or missing dependency image
         id: dependency-changes
@@ -74,17 +74,17 @@ jobs:
           tags: "${{steps.meta-dependency.outputs.tags}}"
           labels: "${{steps.meta-dependency.outputs.labels}}"
 
-      - name: Get number of CPU
+      - name: Get number of cores
         id: get-cores
-        run: |
+        run: |-
           echo "num-threads=$(nproc)" >> $GITHUB_OUTPUT
 
       - name: "Build and push runtime image"
         uses: "docker/build-push-action@471d1dc4e07e5cdedd4c2171150001c434f0b7a4"
         with:
           build-args: |-
-            NUM_THREADS=${{ steps.get-cores.outputs.num-threads }}
-            DEPENDENCY_IMAGE=${{ steps.meta-dependency.outputs.tags }}
+            NUM_THREADS=${{steps.get-cores.outputs.num-threads}}
+            DEPENDENCY_IMAGE=${{steps.meta-dependency.outputs.tags}}
             BASE_IMAGE=ubuntu:22.04
             OSNAME=ubuntu
             EXTRA_CMAKE_FLAGS=-DPRESTO_ENABLE_TESTING=OFF -DPRESTO_ENABLE_PARQUET=ON -DPRESTO_ENABLE_S3=ON

presto-native-execution/scripts/dockerfiles/prestissimo-runtime.dockerfile

@@ -39,8 +39,8 @@ FROM ${BASE_IMAGE}
 ENV BUILD_BASE_DIR=_build
 ENV BUILD_DIR=""
 
-# TODO: This is a temporary fix for issue: https://github.com/prestodb/presto/issues/25531
-# When there is a proper fix, update this piece of code.
+# Temporary fix for https://github.com/prestodb/presto/issues/25531
+# TODO: Update this code when there's a proper fix
 RUN apt-get update && \
     DEBIAN_FRONTEND=noninteractive apt-get install -y tzdata && \
     ln -snf /usr/share/zoneinfo/America/Toronto /etc/localtime && \