feat: Add CLP_WILDCARD_* functions. (#64)

Author: wraymo

presto-clp/src/main/java/com/facebook/presto/plugin/clp/ClpFunctions.java

@@ -65,4 +65,36 @@ public static Block clpGetStringArray(@SqlType(StandardTypes.VARCHAR) Slice json
     {
         throw new UnsupportedOperationException("CLP_GET_STRING_ARRAY is a placeholder function without implementation.");
     }
+
+    @ScalarFunction(value = "CLP_WILDCARD_STRING_COLUMN", deterministic = false)
+    @Description("Used in filter expressions to allow comparisons with any string column in the log record.")
+    @SqlType(StandardTypes.VARCHAR)
+    public static Slice clpWildcardStringColumn()
+    {
+        throw new UnsupportedOperationException("CLP_WILDCARD_STRING_COLUMN is a placeholder function without implementation.");
+    }
+
+    @ScalarFunction(value = "CLP_WILDCARD_INT_COLUMN", deterministic = false)
+    @Description("Used in filter expressions to allow comparisons with any integer column in the log record.")
+    @SqlType(StandardTypes.BIGINT)
+    public static long clpWildcardIntColumn()
+    {
+        throw new UnsupportedOperationException("CLP_WILDCARD_INT_COLUMN is a placeholder function without implementation.");
+    }
+
+    @ScalarFunction(value = "CLP_WILDCARD_FLOAT_COLUMN", deterministic = false)
+    @Description("Used in filter expressions to allow comparisons with any floating point column in the log record.")
+    @SqlType(StandardTypes.DOUBLE)
+    public static double clpWildcardFloatColumn()
+    {
+        throw new UnsupportedOperationException("CLP_WILDCARD_FLOAT_COLUMN is a placeholder function without implementation.");
+    }
+
+    @ScalarFunction(value = "CLP_WILDCARD_BOOL_COLUMN", deterministic = false)
+    @Description("Used in filter expressions to allow comparisons with any boolean column in the log record.")
+    @SqlType(StandardTypes.BOOLEAN)
+    public static boolean clpWildcardBoolColumn()
+    {
+        throw new UnsupportedOperationException("CLP_WILDCARD_BOOL_COLUMN is a placeholder function without implementation.");
+    }
 }

presto-clp/src/main/java/com/facebook/presto/plugin/clp/optimization/ClpFilterToKqlConverter.java

@@ -144,6 +144,11 @@ public ClpExpression visitCall(CallExpression node, Void context)
             }
         }
 
+        String functionName = functionMetadata.getName().getObjectName().toUpperCase();
+        if (functionName.startsWith("CLP_WILDCARD_")) {
+            return new ClpExpression("*");
+        }
+
         return new ClpExpression(node);
     }
 
@@ -233,23 +238,23 @@ private ClpExpression handleBetween(CallExpression node)
             throw new PrestoException(CLP_PUSHDOWN_UNSUPPORTED_EXPRESSION,
                     "BETWEEN operator must have exactly three arguments. Received: " + node);
         }
+
         RowExpression first = arguments.get(0);
         RowExpression second = arguments.get(1);
         RowExpression third = arguments.get(2);
-        if (!(first instanceof VariableReferenceExpression)
-                || !(second instanceof ConstantExpression)
-                || !(third instanceof ConstantExpression)) {
-            return new ClpExpression(node);
-        }
         if (!isClpCompatibleNumericType(first.getType())
                 || !isClpCompatibleNumericType(second.getType())
                 || !isClpCompatibleNumericType(third.getType())) {
             return new ClpExpression(node);
         }
+
         Optional<String> variableOpt = first.accept(this, null).getPushDownExpression();
-        if (!variableOpt.isPresent()) {
+        if (!variableOpt.isPresent()
+                || !(second instanceof ConstantExpression)
+                || !(third instanceof ConstantExpression)) {
             return new ClpExpression(node);
         }
+
         String variable = variableOpt.get();
         String lowerBound = getLiteralString((ConstantExpression) second);
         String upperBound = getLiteralString((ConstantExpression) third);

presto-clp/src/test/java/com/facebook/presto/plugin/clp/TestClpFilterToKql.java

@@ -271,6 +271,39 @@ public void testMetadataSqlGeneration()
                 testMetadataFilterColumns);
     }
 
+    @Test
+    public void testClpWildcardUdf()
+    {
+        SessionHolder sessionHolder = new SessionHolder();
+
+        testPushDown(sessionHolder, "CLP_WILDCARD_STRING_COLUMN() = 'Beijing'", "*: \"Beijing\"", null);
+        testPushDown(sessionHolder, "CLP_WILDCARD_INT_COLUMN() = 1", "*: 1", null);
+        testPushDown(sessionHolder, "CLP_WILDCARD_FLOAT_COLUMN() > 0", "* > 0", null);
+        testPushDown(sessionHolder, "CLP_WILDCARD_BOOL_COLUMN() = true", "*: true", null);
+
+        testPushDown(sessionHolder, "CLP_WILDCARD_STRING_COLUMN() like 'hello%'", "*: \"hello*\"", null);
+        testPushDown(sessionHolder, "substr(CLP_WILDCARD_STRING_COLUMN(), 1, 2) = 'he'", "*: \"he*\"", null);
+        testPushDown(sessionHolder, "CLP_WILDCARD_INT_COLUMN() BETWEEN 0 AND 5", "* >= 0 AND * <= 5", null);
+        testPushDown(sessionHolder, "CLP_WILDCARD_STRING_COLUMN() IN ('hello world', 'hello world 2')", "(*: \"hello world\" OR *: \"hello world 2\")", null);
+
+        testPushDown(sessionHolder, "NOT CLP_WILDCARD_FLOAT_COLUMN() > 0", "NOT * > 0", null);
+        testPushDown(
+                sessionHolder,
+                "CLP_WILDCARD_STRING_COLUMN() = 'Beijing' AND CLP_WILDCARD_INT_COLUMN() = 1 AND city.Region.Id = 1",
+                "((*: \"Beijing\" AND *: 1) AND city.Region.Id: 1)",
+                null);
+        testPushDown(
+                sessionHolder,
+                "CLP_WILDCARD_STRING_COLUMN() = 'Toronto' OR CLP_WILDCARD_INT_COLUMN() = 2",
+                "(*: \"Toronto\" OR *: 2)",
+                null);
+        testPushDown(
+                sessionHolder,
+                "CLP_WILDCARD_STRING_COLUMN() = 'Shanghai' AND (CLP_WILDCARD_INT_COLUMN() = 3 OR city.Region.Id = 5)",
+                "(*: \"Shanghai\" AND (*: 3 OR city.Region.Id: 5))",
+                null);
+    }
+
     private void testPushDown(SessionHolder sessionHolder, String sql, String expectedKql, String expectedRemaining)
     {
         ClpExpression clpExpression = tryPushDown(sql, sessionHolder, ImmutableSet.of());