Skip to content

Commit b0fc053

Browse files
committed
apply review suggestions
1 parent e94e218 commit b0fc053

File tree

4 files changed

+448
-381
lines changed

4 files changed

+448
-381
lines changed

presto-clp/src/main/java/com/facebook/presto/plugin/clp/ClpExpression.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,19 +40,27 @@ public ClpExpression(String definition, RowExpression remainingExpression)
4040
this.remainingExpression = Optional.ofNullable(remainingExpression);
4141
}
4242

43-
// Creates an empty ClpExpression (no KQL definition, no remaining expression).
43+
/**
44+
* Creates an empty ClpExpression (no KQL definition, no remaining expression).
45+
*/
4446
public ClpExpression()
4547
{
46-
this (null, null);
48+
this(null, null);
4749
}
4850

49-
// Creates a ClpExpression from a fully translatable KQL string.
51+
/**
52+
* Creates a ClpExpression from a fully translatable KQL string.
53+
* @param definition
54+
*/
5055
public ClpExpression(String definition)
5156
{
5257
this(definition, null);
5358
}
5459

55-
// Creates a ClpExpression from a non-translatable RowExpression.
60+
/**
61+
* Creates a ClpExpression from a non-translatable RowExpression.
62+
* @param remainingExpression
63+
*/
5664
public ClpExpression(RowExpression remainingExpression)
5765
{
5866
this(null, remainingExpression);

0 commit comments

Comments
 (0)