Skip to content

Commit d501fb5

Browse files
committed
use correct type annotation
1 parent 13bf115 commit d501fb5

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

presto-clp/src/main/java/com/facebook/presto/plugin/clp/ClpFunctions.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,20 @@ private ClpFunctions()
2626
{
2727
}
2828

29-
@ScalarFunction(value = "CLP_GET_INT", deterministic = false)
29+
@ScalarFunction(value = "CLP_GET_BIGINT", deterministic = false)
3030
@Description("Retrieves an integer value corresponding to the given JSON path.")
3131
@SqlType(StandardTypes.BIGINT)
32-
public static long clpGetInt(@SqlType(StandardTypes.VARCHAR) Slice jsonPath)
32+
public static long clpGetBigint(@SqlType(StandardTypes.VARCHAR) Slice jsonPath)
3333
{
34-
throw new UnsupportedOperationException("CLP_GET_INT is a placeholder function without implementation.");
34+
throw new UnsupportedOperationException("CLP_GET_BIGINT is a placeholder function without implementation.");
3535
}
3636

37-
@ScalarFunction(value = "CLP_GET_FLOAT", deterministic = false)
37+
@ScalarFunction(value = "CLP_GET_DOUBLE", deterministic = false)
3838
@Description("Retrieves a floating point value corresponding to the given JSON path.")
3939
@SqlType(StandardTypes.DOUBLE)
40-
public static double clpGetFloat(@SqlType(StandardTypes.VARCHAR) Slice jsonPath)
40+
public static double clpGetDouble(@SqlType(StandardTypes.VARCHAR) Slice jsonPath)
4141
{
42-
throw new UnsupportedOperationException("CLP_GET_FLOAT is a placeholder function without implementation.");
42+
throw new UnsupportedOperationException("CLP_GET_DOUBLE is a placeholder function without implementation.");
4343
}
4444

4545
@ScalarFunction(value = "CLP_GET_BOOL", deterministic = false)

presto-clp/src/test/java/com/facebook/presto/plugin/clp/TestClpUdfRewriter.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ public void testScanFilter()
147147

148148
Plan plan = localQueryRunner.createPlan(
149149
session,
150-
"SELECT * FROM test WHERE CLP_GET_INT('user_id') = 0 AND CLP_GET_FLOAT('fare') < 50.0 AND CLP_GET_STRING('city') = 'SF' AND " +
150+
"SELECT * FROM test WHERE CLP_GET_BIGINT('user_id') = 0 AND CLP_GET_DOUBLE('fare') < 50.0 AND CLP_GET_STRING('city') = 'SF' AND " +
151151
"CLP_GET_BOOL('isHoliday') = true AND cardinality(CLP_GET_STRING_ARRAY('tags')) > 0 AND LOWER(city.Name) = 'beijing'",
152152
WarningCollector.NOOP);
153153
ClpUdfRewriter udfRewriter = new ClpUdfRewriter(functionAndTypeManager);
@@ -186,7 +186,7 @@ public void testScanProject()
186186

187187
Plan plan = localQueryRunner.createPlan(
188188
session,
189-
"SELECT CLP_GET_INT('user_id'), CLP_GET_FLOAT('fare'), CLP_GET_STRING('user'), " +
189+
"SELECT CLP_GET_BIGINT('user_id'), CLP_GET_DOUBLE('fare'), CLP_GET_STRING('user'), " +
190190
"CLP_GET_BOOL('isHoliday'), CLP_GET_STRING_ARRAY('tags'), city.Name FROM test",
191191
WarningCollector.NOOP);
192192
ClpUdfRewriter udfRewriter = new ClpUdfRewriter(functionAndTypeManager);
@@ -202,9 +202,9 @@ public void testScanProject()
202202
anyTree(
203203
project(
204204
ImmutableMap.of(
205-
"clp_get_int",
205+
"clp_get_bigint",
206206
PlanMatchPattern.expression("user_und_id"),
207-
"clp_get_float",
207+
"clp_get_double",
208208
PlanMatchPattern.expression("fare"),
209209
"clp_get_string",
210210
PlanMatchPattern.expression("user"),
@@ -236,7 +236,7 @@ public void testScanProjectFilter()
236236

237237
Plan plan = localQueryRunner.createPlan(
238238
session,
239-
"SELECT LOWER(city.Name), LOWER(CLP_GET_STRING('city.Name')) from test WHERE CLP_GET_INT('user_id') = 0 AND LOWER(city.Name) = 'beijing'",
239+
"SELECT LOWER(city.Name), LOWER(CLP_GET_STRING('city.Name')) from test WHERE CLP_GET_BIGINT('user_id') = 0 AND LOWER(city.Name) = 'beijing'",
240240
WarningCollector.NOOP);
241241
ClpUdfRewriter udfRewriter = new ClpUdfRewriter(functionAndTypeManager);
242242
PlanNode optimizedPlan = udfRewriter.optimize(plan.getRoot(), session.toConnectorSession(), variableAllocator, planNodeIdAllocator);

0 commit comments

Comments
 (0)