Address comments

Author: anlowee

presto-clp/src/main/java/com/facebook/presto/plugin/clp/ClpErrorCode.java

@@ -30,7 +30,8 @@ public enum ClpErrorCode
     CLP_UNSUPPORTED_CONFIG_OPTION(4, EXTERNAL),
 
     CLP_SPLIT_FILTER_CONFIG_NOT_FOUND(10, USER_ERROR),
-    CLP_MANDATORY_SPLIT_FILTER_NOT_VALID(11, USER_ERROR);
+    CLP_MANDATORY_SPLIT_FILTER_NOT_VALID(11, USER_ERROR),
+    CLP_UNSUPPORTED_SPLIT_FILTER_SOURCE(12, EXTERNAL);
 
     private final ErrorCode errorCode;
 

presto-clp/src/main/java/com/facebook/presto/plugin/clp/ClpModule.java

@@ -29,6 +29,7 @@
 import static com.facebook.presto.plugin.clp.ClpConfig.SplitFilterProviderType;
 import static com.facebook.presto.plugin.clp.ClpConfig.SplitProviderType;
 import static com.facebook.presto.plugin.clp.ClpErrorCode.CLP_UNSUPPORTED_METADATA_SOURCE;
+import static com.facebook.presto.plugin.clp.ClpErrorCode.CLP_UNSUPPORTED_SPLIT_FILTER_SOURCE;
 import static com.facebook.presto.plugin.clp.ClpErrorCode.CLP_UNSUPPORTED_SPLIT_SOURCE;
 
 public class ClpModule
@@ -48,6 +49,9 @@ protected void setup(Binder binder)
         if (SplitFilterProviderType.MYSQL == config.getSplitFilterProviderType()) {
             binder.bind(ClpSplitFilterProvider.class).to(ClpMySqlSplitFilterProvider.class).in(Scopes.SINGLETON);
         }
+        else {
+            throw new PrestoException(CLP_UNSUPPORTED_SPLIT_FILTER_SOURCE, "Unsupported split filter provider type: " + config.getSplitFilterProviderType());
+        }
 
         if (config.getMetadataProviderType() == MetadataProviderType.MYSQL) {
             binder.bind(ClpMetadataProvider.class).to(ClpMySqlMetadataProvider.class).in(Scopes.SINGLETON);