From 66e5ddb3353d541353e3d36b48c48506c09c824e Mon Sep 17 00:00:00 2001 From: sitaowang1998 Date: Thu, 13 Nov 2025 13:14:06 -0500 Subject: [PATCH 1/6] Fix GH workflow cache key --- .github/workflows/code-linting-checks.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/code-linting-checks.yaml b/.github/workflows/code-linting-checks.yaml index b5f2e34b..3aeaca1b 100644 --- a/.github/workflows/code-linting-checks.yaml +++ b/.github/workflows/code-linting-checks.yaml @@ -63,7 +63,7 @@ jobs: .task/checksum/lint-cpp-static-check .task/checksum/utils-cpp-lint-clang-tidy-* build/lint-clang-tidy - key: "main-branch-ubuntu-latest-lint:cpp-static-check" + key: "lint:check-cpp-static-on-ubuntu-latest" - run: "task lint:check -C $(nproc)" @@ -78,4 +78,9 @@ jobs: .task/checksum/lint-cpp-static-check .task/checksum/utils-cpp-lint-clang-tidy-* build/lint-clang-tidy - key: "${{steps.cache-restore-lint-cpp-static-check.outputs.cache-primary-key}}" + key: >- + lint:check-cpp-static-on-ubuntu-latest{{hashFiles( + '.task/checksum/lint-cpp-static-check', + '.task/checksum/utils-cpp-lint-clang-tidy-*' + 'build/lint-clang-tidy/**/*' + )}} From 74ea5b7e2d63c7df4eaf759661cddd0038b29ad6 Mon Sep 17 00:00:00 2001 From: sitaowang1998 Date: Mon, 17 Nov 2025 11:39:58 -0500 Subject: [PATCH 2/6] Bug fix --- .github/workflows/code-linting-checks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/code-linting-checks.yaml b/.github/workflows/code-linting-checks.yaml index 3aeaca1b..a32569aa 100644 --- a/.github/workflows/code-linting-checks.yaml +++ b/.github/workflows/code-linting-checks.yaml @@ -79,7 +79,7 @@ jobs: .task/checksum/utils-cpp-lint-clang-tidy-* build/lint-clang-tidy key: >- - lint:check-cpp-static-on-ubuntu-latest{{hashFiles( + lint:check-cpp-static-on-ubuntu-latest-${{hashFiles( '.task/checksum/lint-cpp-static-check', '.task/checksum/utils-cpp-lint-clang-tidy-*' 'build/lint-clang-tidy/**/*' From 753d94ed679214ebe246b40f3c7bd97ac595ab14 Mon Sep 17 00:00:00 2001 From: sitaowang1998 Date: Mon, 17 Nov 2025 11:45:56 -0500 Subject: [PATCH 3/6] Bug fix --- .github/workflows/code-linting-checks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/code-linting-checks.yaml b/.github/workflows/code-linting-checks.yaml index a32569aa..2179c7a6 100644 --- a/.github/workflows/code-linting-checks.yaml +++ b/.github/workflows/code-linting-checks.yaml @@ -81,6 +81,6 @@ jobs: key: >- lint:check-cpp-static-on-ubuntu-latest-${{hashFiles( '.task/checksum/lint-cpp-static-check', - '.task/checksum/utils-cpp-lint-clang-tidy-*' + '.task/checksum/utils-cpp-lint-clang-tidy-*', 'build/lint-clang-tidy/**/*' )}} From 3fa688f1f318f5fa44b7917ae6e639f2a6620fbb Mon Sep 17 00:00:00 2001 From: sitaowang1998 Date: Tue, 6 Jan 2026 20:53:23 -0500 Subject: [PATCH 4/6] Apply suggestions from code review Co-authored-by: Lin Zhihao <59785146+LinZhihao-723@users.noreply.github.com> --- .github/workflows/code-linting-checks.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/code-linting-checks.yaml b/.github/workflows/code-linting-checks.yaml index 2179c7a6..af34b9e6 100644 --- a/.github/workflows/code-linting-checks.yaml +++ b/.github/workflows/code-linting-checks.yaml @@ -63,6 +63,13 @@ jobs: .task/checksum/lint-cpp-static-check .task/checksum/utils-cpp-lint-clang-tidy-* build/lint-clang-tidy + + # NOTE: + # * This key must be kept in-sync with the key prefix in the `actions/cache/save` step + # below (we can't use the output of the current step since `schedule` workflow runs + # don't run this step). + # * Do not provide an exact (explicit) key here. Use a prefix so the cache action can + # match and restore the most recent cache entry that shares that prefix.y. key: "lint:check-cpp-static-on-ubuntu-latest" - run: "task lint:check -C $(nproc)" @@ -78,6 +85,9 @@ jobs: .task/checksum/lint-cpp-static-check .task/checksum/utils-cpp-lint-clang-tidy-* build/lint-clang-tidy + + # NOTE: This key prefix (without the hash) must be kept in-sync with the + # `actions/cache/restore` step above. key: >- lint:check-cpp-static-on-ubuntu-latest-${{hashFiles( '.task/checksum/lint-cpp-static-check', From 3ec6b514ccd3b057b3369ec372d4822e6d65ca0c Mon Sep 17 00:00:00 2001 From: sitaowang1998 Date: Tue, 6 Jan 2026 20:53:52 -0500 Subject: [PATCH 5/6] Apply suggestions from code review Co-authored-by: Lin Zhihao <59785146+LinZhihao-723@users.noreply.github.com> --- .github/workflows/code-linting-checks.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/code-linting-checks.yaml b/.github/workflows/code-linting-checks.yaml index af34b9e6..554d2338 100644 --- a/.github/workflows/code-linting-checks.yaml +++ b/.github/workflows/code-linting-checks.yaml @@ -53,7 +53,10 @@ jobs: run: "task deps:lib_install" # NOTE: We don't use the cache for scheduled runs so that they run lint:cpp-static-check - # on all files. + # NOTE: We don't restore the cache for `schedule` runs so that below, + # `lint:cpp-static-check` runs on all files. If we don't do this periodically, + # `lint:cpp-static-check` could miss issues in files that haven't changed but depend on + # files which have changed. - if: "'schedule' != github.event_name" name: "Restore lint:cpp-static-check cache" id: "cache-restore-lint-cpp-static-check" From 595a61b4a09c9fb20f880d0de7d930821cea0e1b Mon Sep 17 00:00:00 2001 From: sitaowang1998 Date: Tue, 6 Jan 2026 21:03:38 -0500 Subject: [PATCH 6/6] Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- .github/workflows/code-linting-checks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/code-linting-checks.yaml b/.github/workflows/code-linting-checks.yaml index 554d2338..f85dc197 100644 --- a/.github/workflows/code-linting-checks.yaml +++ b/.github/workflows/code-linting-checks.yaml @@ -72,7 +72,7 @@ jobs: # below (we can't use the output of the current step since `schedule` workflow runs # don't run this step). # * Do not provide an exact (explicit) key here. Use a prefix so the cache action can - # match and restore the most recent cache entry that shares that prefix.y. + # match and restore the most recent cache entry that shares that prefix. key: "lint:check-cpp-static-on-ubuntu-latest" - run: "task lint:check -C $(nproc)"