Skip to content

Worker crashes when use IS NOT NULL for TIMESTAMP type. #27

@anlowee

Description

@anlowee

Bug description

As @gibber9809 mentioned:
This maybe related to y-scope/clp#1096 tbh
Or rather it is related -- the pass currently makes assumptions that you're trying to compare timestamps against literals that can be interpreted as timestamps
Pretty much just need to add some special cases in that pass for when the literal is a wildcard, for when the literal otherwise can't be interpreted as a timestamp, and for when there is no literal (e.g. because it is doing an operation like EXISTS/NEXISTS which doesn't have an associated literal).

System information

Velox System Info v0.0.2
Commit: d78134d
CMake Version: 3.28.3
System: Linux-4.15.0-210-generic
Arch: x86_64
C++ Compiler: /usr/bin/c++
C++ Compiler Version: 11.4.0
C Compiler: /usr/bin/cc
C Compiler Version: 11.4.0
CMake Prefix Path: /usr/local;/usr;/;/usr/local/lib/python3.10/dist-packages/cmake/data;/usr/local;/usr/X11R6;/usr/pkg;/opt

Relevant logs

I0829 18:36:02.057405 26501 TaskManager.cpp:589] Adding 1 splits to 20250829_183545_00003_irihr.1.0.0.0 for node 463
I0829 18:36:02.061097 26556 TaskManager.cpp:589] Adding 0 splits to 20250829_183545_00003_irihr.1.0.0.0 for node 463
I0829 18:36:02.061118 26556 TaskManager.cpp:614] No more splits for 20250829_183545_00003_irihr.1.0.0.0 for node 463
I0829 18:36:02.063035 26538 TaskManager.cpp:453] Processing pending result request for task 20250829_183545_00003_irihr.0.0.0.0, buffer 0, sequence 0
I0829 18:36:02.063242 26538 TaskManager.cpp:589] Adding 1 splits to 20250829_183545_00003_irihr.0.0.0.0 for node 393
*** Aborted at 1756492562 (Unix time, try 'date -d @1756492562') ***
*** Signal 11 (SIGSEGV) (0x8) received by PID 26467 (pthread TID 0x7f6419ffb640) (linux TID 26544) (code: address not mapped to object), stack trace: ***
I0829 18:36:02.067058 26559 TaskManager.cpp:1001] TaskManager::getResults task:20250829_183545_00003_irihr.1.0.0.0, destination:0, token:0
I0829 18:36:02.077739 26559 TaskManager.cpp:589] Adding 0 splits to 20250829_183545_00003_irihr.0.0.0.0 for node 393
I0829 18:36:02.077770 26559 TaskManager.cpp:614] No more splits for 20250829_183545_00003_irihr.0.0.0.0 for node 393
    @ 0000000005ab2ee6 _ZN5folly10symbolizer12_GLOBAL__N_118innerSignalHandlerEiP9siginfo_tPv
                       /build/deps-download/folly/folly/debugging/symbolizer/SignalHandler.cpp:453
    @ 0000000005ab2fcc _ZN5folly10symbolizer12_GLOBAL__N_113signalHandlerEiP9siginfo_tPv
                       /build/deps-download/folly/folly/debugging/symbolizer/SignalHandler.cpp:474
    @ 000000000004251f (unknown)
    @ 0000000000aed05b _ZN5clp_s6search22EvaluateTimestampIndex3runERKSt10shared_ptrINS0_3ast10ExpressionEE
    @ 0000000002419c34 _ZN8facebook5velox9connector3clp10search_lib9ClpCursor11loadArchiveEv
    @ 000000000241b46c _ZN8facebook5velox9connector3clp10search_lib9ClpCursor9fetchNextEmRKSt10shared_ptrISt6vectorImSaImEEE
    @ 0000000000c101bc _ZN8facebook5velox9connector3clp13ClpDataSource4nextEmRN5folly10SemiFutureINS4_4UnitEEE
    @ 0000000005225944 _ZN8facebook5velox4exec9TableScan9getOutputEv
    @ 00000000050a3988 _ZZN8facebook5velox4exec6Driver11runInternalERSt10shared_ptrIS2_ERS3_INS1_13BlockingStateEERS3_INS0_9RowVectorEEENKUlvE3_clEv
    @ 00000000050a6140 _ZN8facebook5velox4exec6Driver11runInternalERSt10shared_ptrIS2_ERS3_INS1_13BlockingStateEERS3_INS0_9RowVectorEE
    @ 00000000050a7f7c _ZN8facebook5velox4exec6Driver3runESt10shared_ptrIS2_E
    @ 00000000050a8164 _ZN5folly6detail8function5call_IZN8facebook5velox4exec6Driver7enqueueESt10shared_ptrIS6_EEUlvE_Lb1ELb0EvJEEET2_DpT3_RNS1_4DataE
    @ 0000000000d3d1e4 _ZN5folly6detail8function14FunctionTraitsIFvvEEclEv
                       /build/deps-download/folly/folly/Function.h:370
                       -> /build/deps-download/folly/folly/CancellationToken.cpp
    @ 0000000005bd0dc5 _ZN5folly18ThreadPoolExecutor7runTaskERKSt10shared_ptrINS0_6ThreadEEONS0_4TaskE
                       /build/deps-download/folly/folly/lang/Exception.h:359
                       -> /build/deps-download/folly/folly/executors/ThreadPoolExecutor.cpp
    @ 0000000005b56d61 _ZN5folly21CPUThreadPoolExecutor9threadRunESt10shared_ptrINS_18ThreadPoolExecutor6ThreadEE
                       /build/deps-download/folly/folly/executors/CPUThreadPoolExecutor.cpp:364
    @ 0000000005bda55c _ZSt13__invoke_implIvRMN5folly18ThreadPoolExecutorEFvSt10shared_ptrINS1_6ThreadEEERPS1_JRS4_EET_St21__invoke_memfun_derefOT0_OT1_DpOT2_
                       /usr/include/c++/11/bits/invoke.h:74
                       -> /build/deps-download/folly/folly/executors/ThreadPoolExecutor.cpp
    @ 0000000005bd9cd8 _ZSt8__invokeIRMN5folly18ThreadPoolExecutorEFvSt10shared_ptrINS1_6ThreadEEEJRPS1_RS4_EENSt15__invoke_resultIT_JDpT0_EE4typeEOSC_DpOSD_
                       /usr/include/c++/11/bits/invoke.h:96
                       -> /build/deps-download/folly/folly/executors/ThreadPoolExecutor.cpp
    @ 0000000005bd93c5 _ZNSt5_BindIFMN5folly18ThreadPoolExecutorEFvSt10shared_ptrINS1_6ThreadEEEPS1_S4_EE6__callIvJEJLm0ELm1EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE
                       /usr/include/c++/11/functional:420
                       -> /build/deps-download/folly/folly/executors/ThreadPoolExecutor.cpp
    @ 0000000005bd8690 _ZNSt5_BindIFMN5folly18ThreadPoolExecutorEFvSt10shared_ptrINS1_6ThreadEEEPS1_S4_EEclIJEvEET0_DpOT_
                       /usr/include/c++/11/functional:503
                       -> /build/deps-download/folly/folly/executors/ThreadPoolExecutor.cpp
    @ 0000000005bd72cf _ZN5folly6detail8function5call_ISt5_BindIFMNS_18ThreadPoolExecutorEFvSt10shared_ptrINS4_6ThreadEEEPS4_S7_EELb1ELb0EvJEEET2_DpT3_RNS1_4DataE
                       /build/deps-download/folly/folly/Function.h:341
                       -> /build/deps-download/folly/folly/executors/ThreadPoolExecutor.cpp
    @ 00000000000dc252 (unknown)
    @ 0000000000094ac2 (unknown)
    @ 0000000000125a03 clone
Fatal signal handler. Query Id= 20250829_183545_00003_irihr Task Id= 20250829_183545_00003_irihr.1.0.0.0
Segmentation fault (core dumped)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions