Skip to content

Commit 7552645

Browse files
committed
Resolved code review comments.
1 parent 2a38c76 commit 7552645

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

exports/taskfiles/utils/cmake.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,11 @@ tasks:
155155
# omitted, the native build tool's default number is used. See `man cmake`.
156156
# @param {string} [CMAKE_SETTINGS_DIR] The directory where the project's CMake settings file
157157
# should be stored.
158+
# @param {string} [CMAKE_SOURCE_DIR] Relative path from the extracted tarball directory to the
159+
# CMake source directory containing the CMakeLists.txt file. Defaults to ".", meaning the root
160+
# of the extracted directory.
158161
# @param {string[]} [CMAKE_TARGETS] A list of specific targets to build instead of the default
159162
# target.
160-
# @param {string} [CMAKE_SOURCE_DIR] Optional path, relative to SOURCE_DIR, that specifies the
161-
# directory containing CMakeLists.txt to use in the generate step.
162163
install-remote-tar:
163164
internal: true
164165
label: "{{.TASK}}:{{.CMAKE_PACKAGE_NAME}}-{{.TAR_URL}}-{{.INSTALL_PREFIX}}"
@@ -174,15 +175,15 @@ tasks:
174175
{{default "" .CMAKE_JOBS}}
175176
CMAKE_SETTINGS_DIR: >-
176177
{{default "" .CMAKE_SETTINGS_DIR}}
177-
CMAKE_TARGETS:
178-
ref: "default (list) .CMAKE_TARGETS"
179178
CMAKE_SOURCE_DIR: >-
180179
{{default "." .CMAKE_SOURCE_DIR}}
180+
CMAKE_TARGETS:
181+
ref: "default (list) .CMAKE_TARGETS"
181182

182183
# Directory parameters
183184
BUILD_DIR: "{{.WORK_DIR}}/{{.CMAKE_PACKAGE_NAME}}-build"
185+
EXTRACTED_DIR: "{{.WORK_DIR}}/{{.CMAKE_PACKAGE_NAME}}-extracted"
184186
INSTALL_PREFIX: "{{.WORK_DIR}}/{{.CMAKE_PACKAGE_NAME}}-install"
185-
SOURCE_DIR: "{{.WORK_DIR}}/{{.CMAKE_PACKAGE_NAME}}-src"
186187

187188
requires:
188189
vars: ["CMAKE_PACKAGE_NAME", "TAR_SHA256", "TAR_URL", "WORK_DIR"]
@@ -198,7 +199,7 @@ tasks:
198199
BUILD_DIR: "{{.BUILD_DIR}}"
199200
EXTRA_ARGS:
200201
ref: ".CMAKE_GEN_ARGS"
201-
SOURCE_DIR: "{{.SOURCE_DIR}}/{{.CMAKE_SOURCE_DIR}}"
202+
SOURCE_DIR: "{{.EXTRACTED_DIR}}/{{.CMAKE_SOURCE_DIR}}"
202203
- task: "build"
203204
vars:
204205
BUILD_DIR: "{{.BUILD_DIR}}"

0 commit comments

Comments
 (0)