-
Notifications
You must be signed in to change notification settings - Fork 9
Description
Background
Currently, when the misc-include-cleaner check is set as a warning (instead of an error), the clang-tidy tasks do not fail when violations occur. This means that these violations only appear in the logs located at build/lint-clang-tidy and require manual checking by contributors and reviewers.
Problem
This creates a workflow issue as violations may be missed since they don't cause the CI checks to fail. This was identified during PR y-scope/clp#896 where we relaxed the misc-include-cleaner check to a warning level to unblock resolving other clang-tidy violations and to facilitate the addition of more facade headers for third-party libraries.
Proposed Solution
Update the clang-tidy tasks in yscope-dev-utils to properly fail when any clang-tidy violations occur, including warnings from the misc-include-cleaner check. This would ensure that all violations are caught during CI checks, even when they're at the warning level rather than error level.
Additional Context
- PR that identified this issue: y-scope/clp#896
- Comment requesting this issue: Comment Link