Address review comments.

Author: davidlion

CMakeLists.txt

@@ -86,7 +86,7 @@ if(ystdlib_ENABLE_TESTS)
 endif()
 
 # All libraries are required to use the same minimum version of dependencies to avoid issues.
-set(MIN_BOOST_VERSOIN "1.81.0")
+set(MIN_BOOST_VERSION "1.81.0")
 
 add_subdirectory(src/ystdlib)
 

cmake/ystdlib-helpers.cmake

@@ -8,7 +8,7 @@ macro(check_required_arguments_exist REQUIRED_ARG_NAMES)
     set(_NAMES "${REQUIRED_ARG_NAMES}")
     foreach(_NAME IN LISTS _NAMES)
         if(NOT DEFINED ARG_${_NAME} OR ARG_${_NAME} STREQUAL "")
-            message(FATAL_ERROR "Empty value for argument: '${_NAME}'")
+            message(FATAL_ERROR "Missing or empty value for argument: '${_NAME}'")
         endif()
     endforeach()
 endmacro()

examples/CMakeLists.txt

@@ -19,13 +19,13 @@ if(ystdlib-examples_IS_TOP_LEVEL)
     # Include dependency settings if the project isn't being included as a subproject.
     # NOTE: We mark the file optional because if the user happens to have the dependencies
     # installed, this file is not necessary.
-    include("${CMAKE_SOURCE_DIR}/../build/deps/cmake-settings/all.cmake" OPTIONAL)
+    include("${CMAKE_CURRENT_LIST_DIR}/../build/deps/cmake-settings/all.cmake" OPTIONAL)
 endif()
 
 find_package(ystdlib REQUIRED)
 message(STATUS "Found ystdlib ${ystdlib_VERSION}.")
 
-add_executable(linking-tests "${CMAKE_SOURCE_DIR}/src/linking-tests.cpp")
+add_executable(linking-tests "${CMAKE_CURRENT_LIST_DIR}/src/linking-tests.cpp")
 
 target_compile_features(linking-tests PRIVATE cxx_std_20)
 

examples/README.md

@@ -5,7 +5,7 @@ This directory contains example programs that demonstrate how to use the ystdlib
 The example program `linking-tests` references all of ystdlib's library targets to ensure they can
 be installed and linked correctly.
 
-# Requirements
+## Requirements
 
 [Build](../README.md#building) and [install](../README.md#installing) ystdlib. The commands below
 assume you've built and installed ystdlib to `./build/examples/ystdlib`. If you installed it to a

examples/src/linking-tests.cpp

@@ -112,7 +112,7 @@ auto main() -> int {
     }
 
     if (false == test_io_interface()) {
-        std::cerr << "Error: error_handling test failed. Could not use FailureReader.\n";
+        std::cerr << "Error: io_interface test failed. Could not use FailureReader.\n";
         return 3;
     }
 

src/ystdlib/error_handling/CMakeLists.txt

@@ -3,7 +3,7 @@ if(TARGET ystdlib::error_handling)
 endif()
 
 set(BOOST_FIND_PACKAGE_ARGS
-    "${MIN_BOOST_VERSOIN}"
+    "${MIN_BOOST_VERSION}"
     REQUIRED
     COMPONENTS
     headers