Skip to content

Commit 50e9a3d

Browse files
Apply suggestions from code review
Co-authored-by: davidlion <[email protected]>
1 parent 2924dc3 commit 50e9a3d

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS
1212
)
1313

1414
add_executable(dummy)
15-
target_sources(dummy PRIVATE ystdlib/hello.cpp)
15+
target_sources(dummy PRIVATE src/ystdlib/hello.cpp)
1616
target_compile_features(dummy PRIVATE cxx_std_20)

taskfile.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ vars:
99
G_CMAKE_CACHE: "{{.G_BUILD_DIR}}/CMakeCache.txt"
1010
G_COMPILE_COMMANDS_DB: "{{.G_BUILD_DIR}}/compile_commands.json"
1111
# Project-specific variables
12-
G_YSTDLIB_CPP_SRC_DIR: "{{.ROOT_DIR}}/ystdlib"
12+
G_YSTDLIB_CPP_SRC_DIR: "{{.ROOT_DIR}}/src/ystdlib"
1313

1414
tasks:
1515
clean:

taskfiles/lint-cpp.yaml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,9 @@ tasks:
1717
desc: "Runs the C++ linters that identify formatting issues."
1818
sources: &cpp_format_src_files
1919
- "{{.G_LINT_VENV_CHECKSUM_FILE}}"
20-
- "{{.ROOT_DIR}}/**/*.cpp"
21-
- "{{.ROOT_DIR}}/**/*.h"
22-
- "{{.ROOT_DIR}}/**/*.hpp"
23-
- "{{.ROOT_DIR}}/**/*.inc"
20+
- "{{.G_YSTDLIB_CPP_SRC_DIR}}/**/*.cpp"
21+
- "{{.G_YSTDLIB_CPP_SRC_DIR}}/**/*.h"
22+
- "{{.G_YSTDLIB_CPP_SRC_DIR}}/**/*.hpp"
2423
- "{{.ROOT_DIR}}/.clang-format"
2524
- "{{.TASKFILE}}"
2625
deps:
@@ -60,10 +59,9 @@ tasks:
6059
- "{{.G_CMAKE_CACHE}}"
6160
- "{{.G_COMPILE_COMMANDS_DB}}"
6261
- "{{.G_LINT_VENV_CHECKSUM_FILE}}"
63-
- "{{.ROOT_DIR}}/**/*.cpp"
64-
- "{{.ROOT_DIR}}/**/*.h"
65-
- "{{.ROOT_DIR}}/**/*.hpp"
66-
- "{{.ROOT_DIR}}/**/*.inc"
62+
- "{{.G_YSTDLIB_CPP_SRC_DIR}}/**/*.cpp"
63+
- "{{.G_YSTDLIB_CPP_SRC_DIR}}/**/*.h"
64+
- "{{.G_YSTDLIB_CPP_SRC_DIR}}/**/*.hpp"
6765
- "{{.ROOT_DIR}}/.clang-tidy"
6866
- "{{.TASKFILE}}"
6967
deps:

0 commit comments

Comments
 (0)