Skip to content

Commit 6bb2234

Browse files
Apply suggestions from code review
Co-authored-by: davidlion <[email protected]>
1 parent 3910e31 commit 6bb2234

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@ project(YSTDLIB_CPP LANGUAGES CXX)
33

44
set(YSTDLIB_CPP_VERSION "0.0.1" CACHE STRING "Project version.")
55

6-
# find_package() uses upper-case <PACKAGENAME>_ROOT variables and prefers the paths specified by
7-
# these variables when looking for library packages.
8-
cmake_policy(SET CMP0144 NEW)
9-
106
# Enable exporting compile commands
117
set(CMAKE_EXPORT_COMPILE_COMMANDS
128
ON

src/.clang-format

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
BasedOnStyle: "InheritParentConfig"
22

33
IncludeCategories:
4-
# NOTE: A header is grouped by first matching regex
5-
# Library headers. Update when adding new libraries.
4+
# NOTE: A header is grouped by first matching regex library headers. Update when adding new
5+
# libraries.
66
# NOTE: clang-format retains leading white-space on a line in violation of the YAML spec.
77
- Regex: "<(ystdlib)"
88
Priority: 3

taskfiles/build.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ tasks:
1515
- task: ":utils:cmake-build"
1616
vars:
1717
BUILD_DIR: "{{.G_BUILD_DIR}}"
18-
JOBS: "{{numCPU}}"
1918

2019
clean:
2120
desc: "Removes all built artifacts."
@@ -28,9 +27,6 @@ tasks:
2827
internal: true
2928
deps:
3029
- ":deps:install-all"
31-
generates:
32-
- "{{.G_CMAKE_CACHE}}"
33-
- "{{.G_COMPILE_COMMANDS_DB}}"
3430
run: "once"
3531
cmds:
3632
- task: ":utils:cmake-generate"

0 commit comments

Comments
 (0)