Skip to content

Commit 6c5bda7

Browse files
Apply suggestions from code review
Co-authored-by: davidlion <[email protected]>
1 parent 8dd5a14 commit 6c5bda7

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

CMake/ystdlib-cpp-helpers.cmake

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
# @param {string[]} REQUIRED_ARGS The list of arguments to check.
22
# @param {string[]} ARG_KEYWORDS_MISSING_VALUES The list of arguments with missing values.
3-
# @param {string} LIB_NAME The library target on which to perform the check.
4-
function(require_argument_values REQUIRED_ARGS ARG_KEYWORDS_MISSING_VALUES LIB_NAME)
3+
# @param {string} TARGET_NAME The target on which to perform the check.
4+
function(require_argument_values REQUIRED_ARGS ARG_KEYWORDS_MISSING_VALUES TARGET_NAME)
55
foreach(arg IN LISTS REQUIRED_ARGS)
66
if("${arg}" IN_LIST ARG_KEYWORDS_MISSING_VALUES)
7-
message(FATAL_ERROR "Missing values for argument '${arg}' in target '${LIB_NAME}'.")
7+
message(FATAL_ERROR "Missing values for argument '${arg}' in target '${TARGET_NAME}'.")
88
endif()
99
endforeach()
1010
endfunction()
1111

1212
# @param {string[]} SOURCE_LIST The list of source files to check.
13-
# @param {bool} IS_HEADER_ONLY Returns whether the list only contains header files.
13+
# @param {bool} IS_HEADER_ONLY Returns TRUE if list only contains header files, FALSE otherwise.
1414
# @param {string} NON_HEADER_FILE Returns the name of the first, if any, non-header file.
1515
function(check_if_header_only SOURCE_LIST IS_HEADER_ONLY NON_HEADER_FILE)
1616
set(_LOCAL_SOURCE_LIST "${${SOURCE_LIST}}")

0 commit comments

Comments
 (0)