Skip to content

Commit 96d2492

Browse files
committed
Address review concerns
1 parent b976e33 commit 96d2492

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,24 @@ project(YSTDLIB_CPP LANGUAGES CXX)
44

55
set(YSTDLIB_CPP_VERSION "0.0.1" CACHE STRING "Project version.")
66

7-
# Require compiler versions that support the necessary C++20 features
7+
# Require compiler versions that support the C++20 features necessary for compiling ystdlib-cpp
88
if("AppleClang" STREQUAL "${CMAKE_CXX_COMPILER_ID}")
9-
set(CMAKE_CXX_COMPILER_MIN_VERSION "16")
9+
set(YSTDLIB_CPP_CMAKE_CXX_COMPILER_MIN_VERSION "16")
1010
elseif("Clang" STREQUAL "${CMAKE_CXX_COMPILER_ID}")
11-
set(CMAKE_CXX_COMPILER_MIN_VERSION "16")
11+
set(YSTDLIB_CPP_CMAKE_CXX_COMPILER_MIN_VERSION "16")
1212
elseif("GNU" STREQUAL "${CMAKE_CXX_COMPILER_ID}")
13-
set(CMAKE_CXX_COMPILER_MIN_VERSION "11.4")
13+
set(YSTDLIB_CPP_CMAKE_CXX_COMPILER_MIN_VERSION "11")
1414
else()
1515
message(
1616
FATAL_ERROR
1717
"Unsupported compiler: ${CMAKE_CXX_COMPILER_ID}. Please use AppleClang, Clang, or GNU."
1818
)
1919
endif()
20-
if("${CMAKE_CXX_COMPILER_VERSION}" VERSION_LESS "${CMAKE_CXX_COMPILER_MIN_VERSION}")
20+
if("${CMAKE_CXX_COMPILER_VERSION}" VERSION_LESS "${YSTDLIB_CPP_CMAKE_CXX_COMPILER_MIN_VERSION}")
2121
message(
2222
FATAL_ERROR
2323
"${CMAKE_CXX_COMPILER_ID} version ${CMAKE_CXX_COMPILER_VERSION} is too low. Must be at \
24-
least ${CMAKE_CXX_COMPILER_MIN_VERSION}."
24+
least ${YSTDLIB_CPP_CMAKE_CXX_COMPILER_MIN_VERSION}."
2525
)
2626
endif()
2727

0 commit comments

Comments
 (0)