Skip to content

Commit 9ef42c1

Browse files
Apply suggestions from code review
Co-authored-by: kirkrodrigues <[email protected]>
1 parent 7f5e228 commit 9ef42c1

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

.github/workflows/unit-tests.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,12 @@ jobs:
4343
run: "npm install -g @go-task/cli"
4444

4545
- if: "'macos-14' == matrix.os"
46-
name: "Install macOS 14 deps: coreutils (for md5sum)"
46+
name: "Install coreutils (for md5sum)"
4747
run: |-
4848
brew install coreutils
4949
5050
- name: "Run unit tests and examples"
51+
5152
# Currently unit tests rely on cassert and fail to compile in release mode.
5253
run: |-
5354
task test:run-debug

cmake/Toolchains/utils.cmake

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,7 @@
22
# with the C++20 features required by the project.
33

44
# Checks if the compiler ID and version meet the minimum requirements to support C++20 features
5-
# required by the project:
6-
# - AppleClang: version 15+
7-
# - Clang: version 15+
8-
# - GNU: version 11+
5+
# required by the project.
96
function(validate_compiler_versions)
107
if("AppleClang" STREQUAL "${CMAKE_CXX_COMPILER_ID}")
118
set(CXX_COMPILER_MIN_VERSION "15")

0 commit comments

Comments
 (0)