Skip to content

Commit a1ff0a1

Browse files
committed
Address coderabbitai review
1 parent 0278f6d commit a1ff0a1

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

CMakeLists.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,17 @@
11
cmake_minimum_required(VERSION 3.16.3)
22

33
# Force minimum compiler versions to support full C++20 features
4-
set(CMAKE_CXX_COMPILER_MIN_VERSION "")
54
if("AppleClang" STREQUAL "${CMAKE_CXX_COMPILER_ID}")
65
set(CMAKE_CXX_COMPILER_MIN_VERSION "16")
76
elseif("Clang" STREQUAL "${CMAKE_CXX_COMPILER_ID}")
87
set(CMAKE_CXX_COMPILER_MIN_VERSION "16")
98
elseif("GNU" STREQUAL "${CMAKE_CXX_COMPILER_ID}")
109
set(CMAKE_CXX_COMPILER_MIN_VERSION "11.4")
10+
else()
11+
# Unset the minimum required version variable so the comparison test always evaluates to true
12+
set(CMAKE_CXX_COMPILER_MIN_VERSION "")
1113
endif()
12-
if(${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS ${CMAKE_CXX_COMPILER_MIN_VERSION})
14+
if("${CMAKE_CXX_COMPILER_VERSION}" VERSION_LESS "${CMAKE_CXX_COMPILER_MIN_VERSION}")
1315
message(
1416
FATAL_ERROR
1517
"${CMAKE_CXX_COMPILER_ID} version must be at least ${CMAKE_CXX_COMPILER_MIN_VERSION}!"

0 commit comments

Comments
 (0)