Skip to content

Commit ac3718a

Browse files
committed
Remove NOLINTs
1 parent 861db84 commit ac3718a

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

src/ystdlib/io_interface/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ cpp_library(
77
WriterInterface.hpp
88
PRIVATE_SOURCES
99
ReaderInterface.cpp
10+
PUBLIC_LINK_LIBRARIES
11+
ystdlib::wrapped_facade_headers
1012
TESTS_SOURCES
1113
test/test_ReaderInterface.cpp
1214
test/test_WriterInterface.cpp

src/ystdlib/io_interface/ReaderInterface.hpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
#ifndef YSTDLIB_IO_INTERFACE_READERINTERFACE_HPP
22
#define YSTDLIB_IO_INTERFACE_READERINTERFACE_HPP
33

4-
// TODO: https://github.com/y-scope/ystdlib-cpp/issues/50
5-
// NOLINTNEXTLINE(misc-include-cleaner)
6-
#include <sys/types.h>
7-
84
#include <cstddef>
95
#include <string>
106

7+
#include <ystdlib/wrapped_facade_headers/sys/types.h>
8+
119
#include "ErrorCode.hpp"
1210

1311
namespace ystdlib::io_interface {
@@ -77,8 +75,6 @@ class ReaderInterface {
7775
* Seeks from the current position to the next position by the given offset amount.
7876
* @param offset
7977
*/
80-
// TODO: https://github.com/y-scope/ystdlib-cpp/issues/50
81-
// NOLINTNEXTLINE(misc-include-cleaner)
8278
[[nodiscard]] virtual auto seek_from_current(off_t offset) -> ErrorCode = 0;
8379

8480
/**

src/ystdlib/io_interface/WriterInterface.hpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
#ifndef YSTDLIB_IO_INTERFACE_WRITERINTERFACE_HPP
22
#define YSTDLIB_IO_INTERFACE_WRITERINTERFACE_HPP
33

4-
// TODO: https://github.com/y-scope/ystdlib-cpp/issues/50
5-
// NOLINTNEXTLINE(misc-include-cleaner)
6-
#include <sys/types.h>
7-
84
#include <cstddef>
95
#include <string>
106

7+
#include <ystdlib/wrapped_facade_headers/sys/types.h>
8+
119
#include "ErrorCode.hpp"
1210

1311
namespace ystdlib::io_interface {
@@ -71,8 +69,6 @@ class WriterInterface {
7169
* Seeks from the current position to the next position by the given offset amount.
7270
* @param offset
7371
*/
74-
// TODO: https://github.com/y-scope/ystdlib-cpp/issues/50
75-
// NOLINTNEXTLINE(misc-include-cleaner)
7672
[[nodiscard]] virtual auto seek_from_current(off_t offset) -> ErrorCode = 0;
7773

7874
/**

0 commit comments

Comments
 (0)