Sprint-1 Audit Report by gafram #5
Description
yAcademy RLN - Rate Limiting Nullifier Review
Review Resources:
- Circom circuits at Rate-Limiting-Nullifier Repo
Auditors:
Table of Contents
- Review Summary
- Scope
- Findings Explanation
- Critical Findings
- High Findings
- Medium Findings
- Low Findings
- Final remarks
Review Summary
RLN - Rate Limiting nullifier
RLN (Rate-Limiting Nullifier) is a zk-gadget/protocol that enables spam prevention mechanism for anonymous environments.
The contracts of the RLN Repo were reviewed over 12 days. The code review was performed between 31st May and 12th June, 2023. The repository was under active development during the review, but the review was limited to the latest commit at the start of the review. This was commit 3707313 for the circom-rln repo.
Scope
The scope of the review consisted of the following contracts at the specific commit:
Findings Explanation
Findings are broken down into sections by their respective impact:
- Critical, High, Medium, Low impact
- These are findings that range from attacks that may cause loss of funds, impact control/ownership of the contracts, or cause any unintended consequences/actions that are outside the scope of the requirements
- Gas savings
- Findings that can improve the gas efficiency of the contracts
Critical Findings
None.
High Findings
None.
Medium Findings
None.
Low Findings
1. Low - Unused address input signal to be optimized by Circom
In the withdraw circuit input signal address was declared but never used in constraint. By default, Circom compiler optimized that kind of signals.
template Withdraw() {
signal input identitySecret;
signal input address;
signal output identityCommitment <== Poseidon(1)([identitySecret]);
}
Recommendation
Explicitly add additional constraint on the input signal address.
Final remarks
There are no critical, high, medium vulnerabilities in the code. The findings related to the smart contract were not taken into consideration. An interesting technique is used to preserve the first degree of the polynomial in the Shamir's Secret Sharing. Should also note the need to update the documentation, there are some inconsistencies.