Fix for Bug: Failed to find the PHP version for c:/Program Files/php-8.2.18-Win32-vs16-x64 #11

yCodeTech · yCodeTech · commit de337c7fce5f · 2024-05-17T15:30:07.000+01:00
The underlying cmd command to find the php.exe file and echo it's version fails if there is a space in the path, like `c:/Program Files/php-8.2.18-Win32-vs16-x64`. Fixes #11 by surrounding the path in quotes.
diff --git a/cli/Valet/PhpCgi.php b/cli/Valet/PhpCgi.php
@@ -215,7 +215,7 @@ public function findPhpVersion($phpPath) {
 			return null;
 		}
 
-		$phpVersion = $this->cli->runOrExit("{$phpExecPath} -r \"echo PHP_VERSION;\"",
+		$phpVersion = $this->cli->runOrExit("\"$phpExecPath\" -r \"echo PHP_VERSION;\"",
 			function ($code, $output) use ($phpPath) {
 				error("Failed to find the PHP version for {$phpPath}");
 			}

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ public function findPhpVersion($phpPath) {`
`215`	`215`	`return null;`
`216`	`216`	`}`
`217`	`217`
`218`		`- $phpVersion = $this->cli->runOrExit("{$phpExecPath} -r \"echo PHP_VERSION;\"",`
	`218`	`+ $phpVersion = $this->cli->runOrExit("\"$phpExecPath\" -r \"echo PHP_VERSION;\"",`
`219`	`219`	`function ($code, $output) use ($phpPath) {`
`220`	`220`	`error("Failed to find the PHP version for {$phpPath}");`
`221`	`221`	`}`