Class in default package causes StringIndexOutOfBoundsException

[bernhardf-ro]

A class in the default package causes a StringIndexOutOfBoundsException in the following code:

yGuard/src/main/java/com/yworks/yguard/ant/PackageSection.java

Lines 68 to 79 in 06fc747

	DirectoryScanner scanner = zf.getDirectoryScanner(project);
	scanner.setIncludes(ObfuscatorTask.toNativePattern(ps.getIncludePatterns(project)));
	scanner.setExcludes(ObfuscatorTask.toNativePattern(ps.getExcludePatterns(project)));
	String[] matches = ZipScannerTool.getMatches(zf, scanner);
	for (int i = 0; i < matches.length; i++) {
	String match = matches[i];
	int slashIndex = match.lastIndexOf('/');
	if (match.endsWith(".class") || match.endsWith("/") && slashIndex > 0) {
	match = match.substring(0, slashIndex);
	packages.add(match);
	}
	}

match.substring(0, slashIndex) gets a slashIndex of -1 from match.lastIndexOf('/')

Obfuscating any JAR with a class in the default package should be enough to reproduce the issue.

Ideally such classes would be handled like other classes. But if they are considered unsupported a clear exception would be appreciated.

[Fohlen]

Just out of curiosity @bernhardf-ro did you use unnamed classes? This was a recent addition in Java 21, which would place code in the default package. Otherwise, this behaviour is strongly discouraged. I'm saying this, because this code has worked relatively well for over two decades... 😆

[Fohlen]

Nevermind, it appears unnamed code is placed in the unnamed package. Anyhow - I'm curious as to what your use case is!

[bernhardf-ro]

We do not have any use-case for classes in the default package. We found this issue purely by accident.
However, finding the reason for the exception required looking into the source code. Fixing the exception (as apparently already done) or throwing an exception with clear a message are both equally fine solutions.