fix(coerce-input-value): input object coercion rejects arrays (graphql#4367)

Author: cristunaranjo

src/utilities/__tests__/coerceInputValue-test.ts

@@ -122,12 +122,13 @@ describe('coerceInputValue', () => {
   });
 
   describe('for GraphQLInputObject', () => {
-    const TestInputObject = new GraphQLInputObjectType({
+    const TestInputObject: GraphQLInputObjectType = new GraphQLInputObjectType({
       name: 'TestInputObject',
-      fields: {
+      fields: () => ({
         foo: { type: new GraphQLNonNull(GraphQLInt) },
         bar: { type: GraphQLInt },
-      },
+        nestedObject: { type: TestInputObject },
+      }),
     });
 
     it('returns no error for a valid input', () => {
@@ -153,6 +154,18 @@ describe('coerceInputValue', () => {
     it('invalid for an unknown field', () => {
       test({ foo: 123, unknownField: 123 }, TestInputObject, undefined);
     });
+
+    it('invalid when supplied with an array', () => {
+      test([{ foo: 123 }, { bar: 456 }], TestInputObject, undefined);
+    });
+
+    it('invalid when a nested input object is supplied with an array', () => {
+      test(
+        { foo: 123, nested: [{ foo: 123 }, { bar: 456 }] },
+        TestInputObject,
+        undefined,
+      );
+    });
   });
 
   describe('for GraphQLInputObject that isOneOf', () => {

src/utilities/__tests__/validateInputValue-test.ts

@@ -228,12 +228,13 @@ describe('validateInputValue', () => {
   });
 
   describe('for GraphQLInputObject', () => {
-    const TestInputObject = new GraphQLInputObjectType({
+    const TestInputObject: GraphQLInputObjectType = new GraphQLInputObjectType({
       name: 'TestInputObject',
-      fields: {
+      fields: () => ({
         foo: { type: new GraphQLNonNull(GraphQLInt) },
         bar: { type: GraphQLInt },
-      },
+        nested: { type: TestInputObject },
+      }),
     });
 
     it('returns no error for a valid input', () => {
@@ -292,6 +293,30 @@ describe('validateInputValue', () => {
       ]);
     });
 
+    it('returns error when supplied with an array', () => {
+      test([{ foo: 123 }, { bar: 456 }], TestInputObject, [
+        {
+          error:
+            'Expected value of type "TestInputObject" to be an object, found: [{ foo: 123 }, { bar: 456 }].',
+          path: [],
+        },
+      ]);
+    });
+
+    it('returns error when a nested input object is supplied with an array', () => {
+      test(
+        { foo: 123, nested: [{ foo: 123 }, { bar: 456 }] },
+        TestInputObject,
+        [
+          {
+            error:
+              'Expected value of type "TestInputObject" to be an object, found: [{ foo: 123 }, { bar: 456 }].',
+            path: ['nested'],
+          },
+        ],
+      );
+    });
+
     it('returns error for a misspelled field', () => {
       test({ foo: 123, bart: 123 }, TestInputObject, [
         {

src/utilities/coerceInputValue.ts

@@ -65,7 +65,7 @@ export function coerceInputValue(
   }
 
   if (isInputObjectType(type)) {
-    if (!isObjectLike(inputValue)) {
+    if (!isObjectLike(inputValue) || Array.isArray(inputValue)) {
       return; // Invalid: intentionally return no value.
     }
 

src/utilities/validateInputValue.ts

@@ -107,7 +107,7 @@ function validateInputValueImpl(
       }
     }
   } else if (isInputObjectType(type)) {
-    if (!isObjectLike(inputValue)) {
+    if (!isObjectLike(inputValue) || Array.isArray(inputValue)) {
       reportInvalidValue(
         onError,
         `Expected value of type "${type}" to be an object, found: ${inspect(